Fix endless loop of defer in cloud_build (#32387)

apache · Jul 6, 2023 · becfb3c · becfb3c
1 parent e4757d6
commit becfb3c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/airflow/providers/google/cloud/triggers/cloud_build.py b/airflow/providers/google/cloud/triggers/cloud_build.py
@@ -95,6 +95,7 @@ async def run(self) -> AsyncIterator[TriggerEvent]:  # type: ignore[override]
                             "message": "Build completed",
                         }
                     )
+                    return
                 elif cloud_build_instance._pb.status in (
                     Build.Status.WORKING,
                     Build.Status.PENDING,
@@ -111,14 +112,17 @@ async def run(self) -> AsyncIterator[TriggerEvent]:  # type: ignore[override]
                     Build.Status.EXPIRED,
                 ):
                     yield TriggerEvent({"status": "error", "message": cloud_build_instance.status_detail})
+                    return
                 else:
                     yield TriggerEvent(
                         {"status": "error", "message": "Unidentified status of Cloud Build instance"}
                     )
+                    return
 
             except Exception as e:
                 self.log.exception("Exception occurred while checking for Cloud Build completion")
                 yield TriggerEvent({"status": "error", "message": str(e)})
+                return
 
     def _get_async_hook(self) -> CloudBuildAsyncHook:
         return CloudBuildAsyncHook(gcp_conn_id=self.gcp_conn_id)