Skip to content

Commit

Permalink
Update qubole_hook to not remove pool as an arg for qubole_operator (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
anmol-dhingra committed Sep 11, 2020
1 parent b9dc3c5 commit c58d606
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion airflow/providers/qubole/hooks/qubole.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def flatten_list(list_of_lists):

def filter_options(options):
"""Remove options from the list"""
options_to_remove = ["help", "print-logs-live", "print-logs"]
options_to_remove = ["help", "print-logs-live", "print-logs", "pool"]
return [option for option in options if option not in options_to_remove]


Expand Down
5 changes: 5 additions & 0 deletions tests/providers/qubole/operators/test_qubole.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,3 +177,8 @@ def test_extra_serialized_field(self):
# check for negative case
url2 = simple_task.get_extra_links(datetime(2017, 1, 2), 'Go to QDS')
self.assertEqual(url2, '')

def test_parameter_pool_passed(self):
test_pool = 'test_pool'
op = QuboleOperator(task_id=TASK_ID, pool=test_pool)
self.assertEqual(op.pool, test_pool)

0 comments on commit c58d606

Please sign in to comment.