Skip to content

Commit

Permalink
Simplify checks for package versions
Browse files Browse the repository at this point in the history
Replaces more complex package version checks with one-liners.
  • Loading branch information
potiuk committed Feb 21, 2024
1 parent 70348de commit c67a245
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 16 deletions.
14 changes: 5 additions & 9 deletions airflow/utils/pydantic.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,19 +24,15 @@

from __future__ import annotations

from importlib.metadata import PackageNotFoundError, version

def is_pydantic_2_installed() -> bool:
import sys
from pkg_resources import parse_version

from packaging.version import Version

if sys.version_info >= (3, 9):
from importlib.metadata import distribution
else:
from importlib_metadata import distribution
def is_pydantic_2_installed() -> bool:
try:
return Version(distribution("pydantic").version) >= Version("2.0.0")
except ImportError:
return parse_version(version("pydantic")).major == 2
except PackageNotFoundError:
return False


Expand Down
9 changes: 2 additions & 7 deletions airflow/utils/sqlalchemy.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
from typing import TYPE_CHECKING, Any, Generator, Iterable, overload

from dateutil import relativedelta
from packaging.version import Version, parse as parse_version
from packaging.version import parse as parse_version
from sqlalchemy import TIMESTAMP, PickleType, event, nullsfirst, tuple_
from sqlalchemy.dialects import mysql
from sqlalchemy.types import JSON, Text, TypeDecorator
Expand Down Expand Up @@ -555,10 +555,5 @@ def get_orm_mapper():
return sqlalchemy.orm.mapper if is_sqlalchemy_v1() else sqlalchemy.orm.Mapper


def _get_lib_major_version(lib_name: str) -> int:
ver: Version = parse_version(version(lib_name))
return ver.major


def is_sqlalchemy_v1() -> bool:
return _get_lib_major_version("sqlalchemy") == 1
return parse_version(version("sqlalchemy")).major == 1

0 comments on commit c67a245

Please sign in to comment.