Skip to content

Commit

Permalink
fixup! feat(jobs/triggerer_job_runner): add triggerer canceled log (#…
Browse files Browse the repository at this point in the history
  • Loading branch information
potiuk authored and ephraimbuddy committed Jul 7, 2023
1 parent 62859f0 commit d4afc4d
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions tests/jobs/test_triggerer_job.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,17 @@
import asyncio
import datetime
import importlib
import sys
import time
from threading import Thread
from unittest.mock import MagicMock, patch

if sys.version_info < (3, 8):
# For compatibility with Python 3.7
from asynctest import mock as async_mock
else:
from unittest import mock as async_mock

import pendulum
import pytest

Expand Down Expand Up @@ -257,7 +264,7 @@ def test_trigger_lifecycle(session):

class TestTriggerRunner:
@pytest.mark.asyncio
@patch("airflow.jobs.triggerer_job_runner.TriggerRunner.set_individual_trigger_logging")
@async_mock.patch("airflow.jobs.triggerer_job_runner.TriggerRunner.set_individual_trigger_logging")
async def test_run_trigger_canceled(self, session) -> None:
trigger_runner = TriggerRunner()
trigger_runner.triggers = {1: {"task": MagicMock(), "name": "mock_name", "events": 0}}
Expand All @@ -269,7 +276,7 @@ async def test_run_trigger_canceled(self, session) -> None:
await trigger_runner.run_trigger(1, mock_trigger)

@pytest.mark.asyncio
@patch("airflow.jobs.triggerer_job_runner.TriggerRunner.set_individual_trigger_logging")
@async_mock.patch("airflow.jobs.triggerer_job_runner.TriggerRunner.set_individual_trigger_logging")
async def test_run_trigger_timeout(self, session, caplog) -> None:
trigger_runner = TriggerRunner()
trigger_runner.triggers = {1: {"task": MagicMock(), "name": "mock_name", "events": 0}}
Expand All @@ -281,8 +288,8 @@ async def test_run_trigger_timeout(self, session, caplog) -> None:
await trigger_runner.run_trigger(1, mock_trigger)
assert "Trigger cancelled due to timeout" in caplog.text

@patch("airflow.models.trigger.Trigger.bulk_fetch")
@patch(
@async_mock.patch("airflow.models.trigger.Trigger.bulk_fetch")
@async_mock.patch(
"airflow.jobs.triggerer_job_runner.TriggerRunner.get_trigger_by_classpath",
return_value=DateTimeTrigger,
)
Expand Down

0 comments on commit d4afc4d

Please sign in to comment.