Skip to content

Commit

Permalink
Limit importlib_resources as it breaks pytest_rewrites (#38095)
Browse files Browse the repository at this point in the history
New version of importlib_resources released today - 6.2.0 but also 6.3.0
released few hours later, break pytest_rewrite feature in rather
unexpected ways. Until the problem is diagnosed and solved we should
limit it. The issue is tracked in
python/importlib_resources#299

(cherry picked from commit 7ec2407)
  • Loading branch information
potiuk committed Mar 19, 2024
1 parent 305a516 commit e0192f5
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
2 changes: 1 addition & 1 deletion dev/breeze/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,6 @@ PLEASE DO NOT MODIFY THE HASH BELOW! IT IS AUTOMATICALLY UPDATED BY PRE-COMMIT.

---------------------------------------------------------------------------------------------------------

Package config hash: e2db123fd25e40b515520fb9f6ed32a601fe85e6a22b9845343bc5c81e5785b472527ed3bf6d07521c512d2222f99877a1ce1911ac504a3a6af7b7866aa674cc
Package config hash: eef72be47311fa0b1f3d73e41696365989da51a76db970c2dd012f50f1ad04f1ec97e7c9679b682159aab7fc48785ca8df9422cc57620963f246f6c9d0701f1a

---------------------------------------------------------------------------------------------------------
3 changes: 3 additions & 0 deletions dev/breeze/pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ dependencies = [
"flit>=3.5.0",
"gitpython>=3.1.40",
"hatch==1.9.1",
# Importib_resources 6.2.0 break pytest_rewrite
# see https://github.com/python/importlib_resources/issues/299
"importlib_resources>=5.2,<6.2.0;python_version<\"3.9\"",
"inputimeout>=1.0.4",
"jinja2>=3.1.0",
"jsonschema>=4.19.1",
Expand Down
4 changes: 3 additions & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,9 @@ dependencies = [
"gunicorn>=20.1.0",
"httpx",
"importlib_metadata>=1.7;python_version<\"3.9\"",
"importlib_resources>=5.2;python_version<\"3.9\"",
# Importib_resources 6.2.0 break pytest_rewrite
# see https://github.com/python/importlib_resources/issues/299
"importlib_resources>=5.2,<6.2.0;python_version<\"3.9\"",
"itsdangerous>=2.0",
"jinja2>=3.0.0",
"jsonschema>=4.18.0",
Expand Down

0 comments on commit e0192f5

Please sign in to comment.