Allow SSHOperator.skip_on_exit_code to be zero (#36358)

apache · Dec 21, 2023 · e028e38 · e028e38
1 parent 7084429
commit e028e38
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/airflow/providers/ssh/operators/ssh.py b/airflow/providers/ssh/operators/ssh.py
@@ -114,7 +114,7 @@ def __init__(
             skip_on_exit_code
             if isinstance(skip_on_exit_code, Container)
             else [skip_on_exit_code]
-            if skip_on_exit_code
+            if skip_on_exit_code is not None
             else []
         )
 

diff --git a/tests/providers/ssh/operators/test_ssh.py b/tests/providers/ssh/operators/test_ssh.py
@@ -208,13 +208,19 @@ def test_ssh_client_managed_correctly(self):
         [
             ({}, 0, None),
             ({}, 100, AirflowException),
+            ({}, 101, AirflowException),
             ({"skip_on_exit_code": None}, 0, None),
             ({"skip_on_exit_code": None}, 100, AirflowException),
+            ({"skip_on_exit_code": None}, 101, AirflowException),
+            ({"skip_on_exit_code": 100}, 0, None),
             ({"skip_on_exit_code": 100}, 100, AirflowSkipException),
             ({"skip_on_exit_code": 100}, 101, AirflowException),
+            ({"skip_on_exit_code": 0}, 0, AirflowSkipException),
+            ({"skip_on_exit_code": [100]}, 0, None),
             ({"skip_on_exit_code": [100]}, 100, AirflowSkipException),
             ({"skip_on_exit_code": [100]}, 101, AirflowException),
             ({"skip_on_exit_code": [100, 102]}, 101, AirflowException),
+            ({"skip_on_exit_code": (100,)}, 0, None),
             ({"skip_on_exit_code": (100,)}, 100, AirflowSkipException),
             ({"skip_on_exit_code": (100,)}, 101, AirflowException),
         ],