Skip to content

Commit

Permalink
Fix errors in CHANGELOGS for slack and amazon (#26746)
Browse files Browse the repository at this point in the history
  • Loading branch information
potiuk committed Sep 28, 2022
1 parent 9e06c99 commit ec1615b
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion airflow/providers/amazon/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Breaking changes

.. warning::
In this version of provider Amazon S3 Connection (``conn_type="s3"``) removed due to the fact that it was always
an alias to :ref:`Amazon Web Services Connection <howto/connection:aws>` (``conn_type="aws"``).
an alias to AWS connection ``conn_type="aws"``
In practice the only impact is you won't be able to ``test`` the connection in the web UI / API.
In order to restore ability to test connection you need to change connection type from **Amazon S3** (``conn_type="s3"``)
to **Amazon Web Services** (``conn_type="aws"``) manually.
Expand Down
9 changes: 4 additions & 5 deletions airflow/providers/slack/CHANGELOG.rst
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,10 @@ Changelog
Breaking changes
~~~~~~~~~~~~~~~~

* The hook class :class:`airflow.providers.slack.hooks.slack_webhook.SlackWebhookHook` not inherit from
:class:`airflow.providers.http.hooks.http.HttpHook` anymore. In practice the only impact on
user-defined classes based on **SlackWebhookHook** and you use attributes from **HttpHook**.
* Drop support deprecated ``webhook_token`` parameter in
:ref:`Slack Incoming Webhook Connection <howto/connection:slack-incoming-webhook>` Extra.
* The hook class ``SlackWebhookHook`` dies not inherit from ``HttpHook`` anymore. In practice the
only impact on user-defined classes based on **SlackWebhookHook** and you use attributes
from **HttpHook**.
* Drop support deprecated ``webhook_token`` parameter in ``slack-incoming-webhook`` extra.

* ``Refactor 'SlackWebhookOperator': Get rid of mandatory http-provider dependency (#26648)``
* ``Refactor SlackWebhookHook in order to use 'slack_sdk' instead of HttpHook methods (#26452)``
Expand Down

0 comments on commit ec1615b

Please sign in to comment.