openlineage,gcs: use proper name for openlineage methods (#32956)

Signed-off-by: Maciej Obuchowski <obuchowski.maciej@gmail.com>
apache · Jul 31, 2023 · f9cddf3 · f9cddf3
1 parent 42465c5
commit f9cddf3
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/airflow/providers/google/cloud/transfers/gcs_to_gcs.py b/airflow/providers/google/cloud/transfers/gcs_to_gcs.py
@@ -553,7 +553,7 @@ def _copy_single_object(self, hook, source_object, destination_object):
         if self.move_object:
             hook.delete(self.source_bucket, source_object)
 
-    def get_openlineage_events_on_complete(self, task_instance):
+    def get_openlineage_facets_on_complete(self, task_instance):
         """
         Implementing _on_complete because execute method does preprocessing on internals.
         This means we won't have to normalize self.source_object and self.source_objects,

diff --git a/docs/apache-airflow-providers-openlineage/guides/developer.rst b/docs/apache-airflow-providers-openlineage/guides/developer.rst
@@ -81,7 +81,7 @@ Here's example of properly implemented ``get_openlineage_facets_on_complete`` me
 
 .. code-block::
 
-    def get_openlineage_events_on_complete(self, task_instance):
+    def get_openlineage_facets_on_complete(self, task_instance):
         """
         Implementing _on_complete because execute method does preprocessing on internals.
         This means we won't have to normalize self.source_object and self.source_objects,

diff --git a/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py b/tests/providers/google/cloud/transfers/test_gcs_to_gcs.py
@@ -840,7 +840,7 @@ def test_execute_simple_reports_openlineage(self, mock_hook):
 
         operator.execute(None)
 
-        lineage = operator.get_openlineage_events_on_complete(None)
+        lineage = operator.get_openlineage_facets_on_complete(None)
         assert len(lineage.inputs) == 1
         assert len(lineage.outputs) == 1
         assert lineage.inputs[0] == Dataset(
@@ -862,7 +862,7 @@ def test_execute_multiple_reports_openlineage(self, mock_hook):
 
         operator.execute(None)
 
-        lineage = operator.get_openlineage_events_on_complete(None)
+        lineage = operator.get_openlineage_facets_on_complete(None)
         assert len(lineage.inputs) == 3
         assert len(lineage.outputs) == 1
         assert lineage.inputs == [
@@ -889,7 +889,7 @@ def test_execute_wildcard_reports_openlineage(self, mock_hook):
 
         operator.execute(None)
 
-        lineage = operator.get_openlineage_events_on_complete(None)
+        lineage = operator.get_openlineage_facets_on_complete(None)
         assert len(lineage.inputs) == 2
         assert len(lineage.outputs) == 2
         assert lineage.inputs == [