Skip to content

Commit

Permalink
Add back envvars for mysql and postgres version options (#36914)
Browse files Browse the repository at this point in the history
It turned out that for quite a while we had not run backend
tests for different versions of backends because the options were
defined without envvars. Still tracking how long it was like that,
but this PR should bring tests for the different backend versions
back.
  • Loading branch information
potiuk committed Jan 19, 2024
1 parent 4b8646a commit fba05db
Show file tree
Hide file tree
Showing 7 changed files with 8 additions and 6 deletions.
2 changes: 2 additions & 0 deletions dev/breeze/src/airflow_breeze/commands/common_options.py
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ def _set_default_from_parent(ctx: click.core.Context, option: click.core.Option,
help="Version of MySQL used.",
type=MySQLBackendVersionType(ALLOWED_MYSQL_VERSIONS),
default=CacheableDefault(ALLOWED_MYSQL_VERSIONS[0]),
envvar="MYSQL_VERSION",
show_default=True,
)
option_installation_package_format = click.option(
Expand All @@ -269,6 +270,7 @@ def _set_default_from_parent(ctx: click.core.Context, option: click.core.Option,
"--postgres-version",
type=CacheableChoice(ALLOWED_POSTGRES_VERSIONS),
default=CacheableDefault(ALLOWED_POSTGRES_VERSIONS[0]),
envvar="POSTGRES_VERSION",
show_default=True,
help="Version of Postgres used.",
)
Expand Down
2 changes: 1 addition & 1 deletion images/breeze/output_setup_config.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d2a3542e375dd07a55385bf545b5e199
6187dc8325522faac599433a5827bc25
2 changes: 1 addition & 1 deletion images/breeze/output_shell.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
d0b4fa36683eaa51744c631715f9ffe5
6cf4c81aee480d434f01d04b0f37b630
2 changes: 1 addition & 1 deletion images/breeze/output_start-airflow.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4ad796e7308801391d76089841fb3283
82fb81c651bc48f97bcc080fab22c581
2 changes: 1 addition & 1 deletion images/breeze/output_testing_db-tests.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
4b0ba29824ebb5cb2580b66ab022067e
fbd4a4c9818167fef8113899d3822683
2 changes: 1 addition & 1 deletion images/breeze/output_testing_integration-tests.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
6b3936410fc1ef583fc241616ee8252d
a8e0691c0e14846200b0c2db78e505c6
2 changes: 1 addition & 1 deletion images/breeze/output_testing_tests.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
93dd0156785e1dd5261b555a278a5ebd
66e0dd3fef7ea97e3c07241c16abaf1a

0 comments on commit fba05db

Please sign in to comment.