Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Jinja2 3.x #16591

Closed
ashwin153 opened this issue Jun 22, 2021 · 2 comments · Fixed by #16595
Closed

Support for Jinja2 3.x #16591

ashwin153 opened this issue Jun 22, 2021 · 2 comments · Fixed by #16595
Labels
kind:feature Feature Requests

Comments

@ashwin153
Copy link
Contributor

ashwin153 commented Jun 22, 2021

Description

Currently, Jinja2 is required to be < 2.12.0.

jinja2>=2.10.1, <2.12.0

However, the latest version of Jinja2 is 3.0.1.

Use case / motivation

This causes some build issues in my monorepo, because other libraries depend on Jinja2 3.x but Airflow does not yet support it. I stepped through the git blame, and it doesn't seem like there's a specific reason why Jinja2 3.x is not supported; the upper-bound appears to be there for stability and not incompatibility reasons.

Are you willing to submit a PR?

I would be happy to submit a PR, but I would need some guidance on how to test this change.

@ashwin153 ashwin153 added the kind:feature Feature Requests label Jun 22, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 22, 2021

Thanks for opening your first issue here! Be sure to follow the issue template!

@potiuk
Copy link
Member

potiuk commented Jun 22, 2021

Maybe you can just try it. We run a lot of tests which are using Jinja internally so I think it will be enough to have "Green" PR :).

The only thing you need is to make a PR with limitation for Jinja removed in setup.py/cfg. It will automatically bump Jinja to latest non-conflicting version and run all the tests. If it gets green and other committers will be OK with that we can then merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:feature Feature Requests
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants