Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Jinja2 upper-bound from 2.12.0 to 4.0.0 #16595

Merged
merged 4 commits into from Jun 24, 2021
Merged

Conversation

ashwin153
Copy link
Contributor

@boring-cyborg
Copy link

boring-cyborg bot commented Jun 22, 2021

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

@uranusjr
Copy link
Member

What is the <3.1.0 upper bound for?

@ashwin153
Copy link
Contributor Author

Was just preserving behavior. Will remove.

@ashwin153 ashwin153 changed the title Bump Jinja2 upper-bound from 2.12.0 to 3.1.0 Remove Jinja2 upper-bound Jun 22, 2021
setup.cfg Outdated Show resolved Hide resolved
Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
@ashb ashb added this to the Airflow 2.1.2 milestone Jun 22, 2021
@ashwin153 ashwin153 changed the title Remove Jinja2 upper-bound Bump Jinja2 upper-bound Jun 23, 2021
@ashwin153 ashwin153 changed the title Bump Jinja2 upper-bound Bump Jinja2 upper-bound to 4.0.0 Jun 23, 2021
@ashwin153 ashwin153 changed the title Bump Jinja2 upper-bound to 4.0.0 Bump Jinja2 upper-bound from 2.12.0 to 4.0.0 Jun 23, 2021
@potiuk
Copy link
Member

potiuk commented Jun 24, 2021

Can you please rebase @ashwin153 ?

@potiuk potiuk merged commit 5d5268f into apache:main Jun 24, 2021
@boring-cyborg
Copy link

boring-cyborg bot commented Jun 24, 2021

Awesome work, congrats on your first merged pull request!

@ashb ashb modified the milestones: Airflow 2.1.2, Airflow 2.1.3 Jul 7, 2021
potiuk pushed a commit to potiuk/airflow that referenced this pull request Aug 2, 2021
potiuk pushed a commit to potiuk/airflow that referenced this pull request Aug 5, 2021
kaxil pushed a commit that referenced this pull request Aug 17, 2021
jhtimmins pushed a commit that referenced this pull request Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Jinja2 3.x
4 participants