Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow 2.2.4rc1 #21669

Closed
10 of 40 tasks
jedcunningham opened this issue Feb 18, 2022 · 11 comments
Closed
10 of 40 tasks

Status of testing of Apache Airflow 2.2.4rc1 #21669

jedcunningham opened this issue Feb 18, 2022 · 11 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@jedcunningham
Copy link
Member

jedcunningham commented Feb 18, 2022

Body

We have a kind request for all the contributors to the latest Apache Airflow RC 2.2.4rc1.

Could you please help us to test the RC versions of Airflow?

Please let us know in the comment if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@auvipy @uranusjr @kushsharma @SamWheating @lwyszomi @tsingh2k15 @potiuk @dungdm93 @aa3pankaj @davidcaron @alete89 @BasPH @wanlce @hubert-pietron @ashwin153 @smartnewsdingli @yuqian90 @chenglongyan @blag @jakubczaplicki @lostkamp @ljades @easontm @DrFaust92 @jon-fearer @howardyoo @stablum @josh-fell @Datkros @ignaski @kaushikparanjpe @avkirilishin @o-nikolas @jedcunningham @coinzerge @kaxil @microhuang @collinmcnulty @ecerulm @uplsh580 @boredland @lionheart106008 @ephraimbuddy @satishmittal111

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@jedcunningham jedcunningham added the kind:meta High-level information important to the community label Feb 18, 2022
@jon-fearer
Copy link
Contributor

#20303 Looks good in the RC version

@hubert-pietron
Copy link
Contributor

#20591 Looks good too :)

@wanlce
Copy link
Contributor

wanlce commented Feb 21, 2022

#21011 Looks good too

@aa3pankaj
Copy link
Contributor

#21294 Looks good

@lwyszomi
Copy link
Contributor

#19963 works fine

@josh-fell
Copy link
Contributor

#19608 looks good for what it was designed to fix but I did find some other scenarios that the inference does not handle properly. Mainly when the @task decorator is "called"/has an argument passed directly in the decorator (e.g. @task(task_id="some_task") -> Dict: ... or @task(on_failure_callback=some_func) -> Dict: ... ) the inference does not work.

Although I have verified that this did not work in Airflow 2.2.3 but does function properly on main.

A workaround is to explicitly use multiple_outputs=True in any case. On the main branch, the inference was refactored and no longer uses the function signature with inspect but uses typing_extensions and seems to work much better.

@jedcunningham This isn't a regression because the inference functionality doesn't work with directly passing args to the @task decorator currently. However, do you think logging an issue is warranted here for visibility? I think some unit tests should be added as well to handle this set of scenarios. WDYT?

@jedcunningham
Copy link
Member Author

Yeah, adding some unit tests to main to make sure it doesn't regress in the future sounds good to me.

I assume cherry-picking the refactoring won't be trivial, so it might not be worth an issue for visibility though.

@jedcunningham
Copy link
Member Author

Thanks everyone, 2.2.4 has been released 🎉

@uplsh580
Copy link
Contributor

#21062 LGTM 👍 (I'm sorry for being late.)

@jedcunningham
Copy link
Member Author

No worries, thanks!

@zachliu
Copy link
Contributor

zachliu commented Feb 28, 2022

there is a 🐛 in #18042, sending alert emails using aws ses still doesn't work 😢
gonna open an issue now

issue opened: #21878

@potiuk potiuk added the testing status Status of testing releases label Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

10 participants