-
Notifications
You must be signed in to change notification settings - Fork 13.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to create user in the Remote User mode Auth. #19963
Conversation
I think some common approach here should be worked out. I am for adding it, but I am not as "deeply" in the rules and configuration - I believe for the new UI we are porting FAB permission model to Airlfow. so maybe that's a good time to discuss and agree something there @ashb @jithimmins @bbovenzi @ryanahamilton ? |
@potiuk @jhtimmins Can you, please, review this fix/change one more time. |
This is a sensible change, and looks like it was supported in the original version of It shouldn't be necessary to modify It may be tricky to test though. @kosteev or @lwyszomi can one of y'all verify that the change works as intended and that you can actually add a new user and then log in with that user? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change makes sense. Please see my comment for requested changes, in addition to the merge conflicts.
@jhtimmins I duplicated both values from base Class to easly show that this is needed in the Change is already tested and all works fine. |
5e3d8ba
to
f295bfb
Compare
Hey @jedcunningham - I think that one should be easy to cherry-pick to 2.1.4 and it is a bit of regression (not entirely - this was a change in FAB rather than in Airflow). I marked it as 2.1.4 but maybe you can decide whether to cherry-pick it to 2.2.4 or not. |
(cherry picked from commit cdd9ea6)
(cherry picked from commit cdd9ea6)
(cherry picked from commit cdd9ea6)
This fix gives a possibility to create user in the Remote User Auth. I know that we have open discussion about the same issue in the LDAP mode (#18545), but in the Remote User mode I think this option should be available.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.