Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grid view disappears when hovering over skipped mapped tasks #24620

Closed
1 of 2 tasks
erdos2n opened this issue Jun 23, 2022 · 4 comments
Closed
1 of 2 tasks

Grid view disappears when hovering over skipped mapped tasks #24620

erdos2n opened this issue Jun 23, 2022 · 4 comments
Assignees
@bbovenzi
Labels
area:dynamic-task-mapping AIP-42 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Milestone
Airflow 2.3.3

Comments

@erdos2n
Copy link
Contributor

erdos2n commented Jun 23, 2022

Apache Airflow version

2.3.2 (latest released)

What happened

When hovering over a skipped task of a DAG in the Grid view, the Grid view will disappear. The console contains the following error messages, which point to a skipped task having an unknown length value.

grid.56cb323501b2bfa504f1.js:2 TypeError: Cannot read properties of undefined (reading 'length')
    at BO (grid.56cb323501b2bfa504f1.js:2:715227)
    at ui (grid.56cb323501b2bfa504f1.js:2:228868)
    at Qu (grid.56cb323501b2bfa504f1.js:2:280949)
    at Pl (grid.56cb323501b2bfa504f1.js:2:268222)
    at jl (grid.56cb323501b2bfa504f1.js:2:268150)
    at Cl (grid.56cb323501b2bfa504f1.js:2:268013)
    at bl (grid.56cb323501b2bfa504f1.js:2:265000)
    at grid.56cb323501b2bfa504f1.js:2:214787
    at t.unstable_runWithPriority (grid.56cb323501b2bfa504f1.js:2:291644)
    at Go (grid.56cb323501b2bfa504f1.js:2:214564)
cu @ grid.56cb323501b2bfa504f1.js:2
n.callback @ grid.56cb323501b2bfa504f1.js:2
ma @ grid.56cb323501b2bfa504f1.js:2
gu @ grid.56cb323501b2bfa504f1.js:2
Il @ grid.56cb323501b2bfa504f1.js:2
t.unstable_runWithPriority @ grid.56cb323501b2bfa504f1.js:2
Go @ grid.56cb323501b2bfa504f1.js:2
Tl @ grid.56cb323501b2bfa504f1.js:2
bl @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
t.unstable_runWithPriority @ grid.56cb323501b2bfa504f1.js:2
Go @ grid.56cb323501b2bfa504f1.js:2
Yo @ grid.56cb323501b2bfa504f1.js:2
Xo @ grid.56cb323501b2bfa504f1.js:2
hl @ grid.56cb323501b2bfa504f1.js:2
Ai @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
setTimeout (async)
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Ue @ grid.56cb323501b2bfa504f1.js:2
Xe @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
jr @ grid.56cb323501b2bfa504f1.js:2
Rr @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Le @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Br @ grid.56cb323501b2bfa504f1.js:2
Jt @ grid.56cb323501b2bfa504f1.js:2
Zt @ grid.56cb323501b2bfa504f1.js:2
t.unstable_runWithPriority @ grid.56cb323501b2bfa504f1.js:2
Kt @ grid.56cb323501b2bfa504f1.js:2
grid.56cb323501b2bfa504f1.js:2 Uncaught TypeError: Cannot read properties of undefined (reading 'length')
    at BO (grid.56cb323501b2bfa504f1.js:2:715227)
    at ui (grid.56cb323501b2bfa504f1.js:2:228868)
    at Qu (grid.56cb323501b2bfa504f1.js:2:280949)
    at Pl (grid.56cb323501b2bfa504f1.js:2:268222)
    at jl (grid.56cb323501b2bfa504f1.js:2:268150)
    at Cl (grid.56cb323501b2bfa504f1.js:2:268013)
    at bl (grid.56cb323501b2bfa504f1.js:2:265000)
    at grid.56cb323501b2bfa504f1.js:2:214787
    at t.unstable_runWithPriority (grid.56cb323501b2bfa504f1.js:2:291644)
    at Go (grid.56cb323501b2bfa504f1.js:2:214564)
BO @ grid.56cb323501b2bfa504f1.js:2
ui @ grid.56cb323501b2bfa504f1.js:2
Qu @ grid.56cb323501b2bfa504f1.js:2
Pl @ grid.56cb323501b2bfa504f1.js:2
jl @ grid.56cb323501b2bfa504f1.js:2
Cl @ grid.56cb323501b2bfa504f1.js:2
bl @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
t.unstable_runWithPriority @ grid.56cb323501b2bfa504f1.js:2
Go @ grid.56cb323501b2bfa504f1.js:2
Yo @ grid.56cb323501b2bfa504f1.js:2
Xo @ grid.56cb323501b2bfa504f1.js:2
hl @ grid.56cb323501b2bfa504f1.js:2
Ai @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
setTimeout (async)
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Ue @ grid.56cb323501b2bfa504f1.js:2
Xe @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
jr @ grid.56cb323501b2bfa504f1.js:2
Rr @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Le @ grid.56cb323501b2bfa504f1.js:2
(anonymous) @ grid.56cb323501b2bfa504f1.js:2
Br @ grid.56cb323501b2bfa504f1.js:2
Jt @ grid.56cb323501b2bfa504f1.js:2
Zt @ grid.56cb323501b2bfa504f1.js:2
t.unstable_runWithPriority @ grid.56cb323501b2bfa504f1.js:2
Kt @ grid.56cb323501b2bfa504f1.js:2

What you think should happen instead

The Grid view should not disappear and the panel on the right should contain necessary fields and options for the skipped task.

How to reproduce

Run a DAG with a skipped task and hover over the skipped task, the Grid view should disappear.

Operating System

Mac OS Monterey

Versions of Apache Airflow Providers

apache-airflow-providers-sftp==2.1.1
apache-airflow-providers-snowflake==2.1.1

Deployment

Astronomer

Deployment details

Deployment is on Astronomer Nebula and is Airflow version 2.3.2

Dockerfile

FROM quay.io/astronomer/ap-airflow:2.1.4-7-buster-onbuild

Anything else

Every time

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@erdos2n erdos2n added area:core kind:bug This is a clearly a bug labels Jun 23, 2022
@ashb ashb added this to the Airflow 2.3.3 milestone Jun 23, 2022
@bbovenzi bbovenzi added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Jun 23, 2022
@bbovenzi bbovenzi self-assigned this Jun 23, 2022
@bbovenzi
Copy link
Contributor

@erdos2n Do you have a sample DAG for this? I can't seem to replicate this for just any skipped task.

@ashb
Copy link
Member

ashb commented Jun 24, 2022

I think this was caused by hovering over a skipped mapped task -- i.e. when make_list in our example map dags returns a zero length list.

We may have already fixed this in main for 2.4 with one of our optimization PRs as I can't reproduce it right on main. Checking release.

@ashb
Copy link
Member

ashb commented Jun 24, 2022

Yes, confirmed it's a bug in 2.3.2 but not a problem in main.

@bbovenzi
Copy link
Contributor

It looks like it was fixed in 451a6f4#diff-50b1f3bc397270b30a4ed4928fb0a03896ecae7e9278546acccb5d53bd1c0f38

We also added typechecking in #24509 so we should be able to catch these issues early-on.

@ashb ashb changed the title Grid view disappears when hovering over skipped tasks Grid view disappears when hovering over skipped mapped tasks Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bbovenzi bbovenzi

Labels
area:dynamic-task-mapping AIP-42 area:UI Related to UI/UX. For Frontend Developers. kind:bug This is a clearly a bug
Projects
None yet
Milestone
Airflow 2.3.3
Development

No branches or pull requests
3 participants
@ashb @bbovenzi @erdos2n