Migrate jsx files that affect run/task selection to tsx #24509
Conversation
boring-cyborg
bot
added
area:UI
| endDate: string | null; | ||
| state: TaskState; | ||
| mappedStates?: { | ||
| [key: string]: number; |
There was a problem hiding this comment.
| [key: string]: number; | |
| [key: TaskState]: number; |
If that is allowed
There was a problem hiding this comment.
Unfortunately not to my knowledge.
There was a problem hiding this comment.
You can do something like:
[key in TaskState]: number;
But the | null is an issue here. :(
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
| instance: TaskInstance; | ||
| } | ||
|
|
||
| const InstanceTooltip: React.FC<Props> = ({ |
There was a problem hiding this comment.
Any reason we favor React.FC over:
const MyComponent = ({}: Props): JSX.Element => {}
React.FC was removed in CRA:
facebook/create-react-app#8177
React.FC seems discouraged:
https://github.com/typescript-cheatsheets/react#function-components
There was a problem hiding this comment.
Interesting. You're right. As of React 18, it doesn't make sense anymore. I'll update that.
| endDate: string | null; | ||
| state: TaskState; | ||
| mappedStates?: { | ||
| [key: string]: number; |
There was a problem hiding this comment.
You can do something like:
[key in TaskState]: number;
But the | null is an issue here. :(
* convert all useSelection files to ts Update grid data ts, remove some anys * yarn, lint and tests * convert statusbox to ts * remove some anys, update instance tooltip * fix types * remove any, add comment for global vars * fix url selection and grid/task defaults * remove React.FC declarations * specify tsconfig file path * remove ts-loader (cherry picked from commit c3c1f7e)
ephraimbuddy
added
the
changelog:skip
ephraimbuddy
added
type:bug-fix
In the Grid view, selecting a task or run can be very slow for large DAGs. This is because of some slow querying. I am about to fix that. But I figured it would be safer to make a big change if all the related files were in typescript so issues are caught early.
Partial solution to: #24350
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragement file, named
{pr_number}.significant.rst, in newsfragments.