Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve web ui views warning re DISTINCT ON #26607

Closed
1 task done
dstandish opened this issue Sep 22, 2022 · 0 comments · Fixed by #26608
Closed
1 task done

resolve web ui views warning re DISTINCT ON #26607

dstandish opened this issue Sep 22, 2022 · 0 comments · Fixed by #26608
Labels
kind:meta High-level information important to the community

Comments

@dstandish
Copy link
Contributor

Body

Got this warning in webserver output when loading home page

/Users/dstandish/code/airflow/airflow/www/views.py:710 SADeprecationWarning: DISTINCT ON is currently supported only by the PostgreSQL dialect.  Use of DISTINCT ON for other backends is currently silently ignored, however this usage is deprecated, and will raise CompileError in a future release for all backends that do not support this syntax.

looks like it's this line

            dagtags = session.query(DagTag.name).distinct(DagTag.name).all()

may be able to change to func.distinct

Committer

  • I acknowledge that I am a maintainer/committer of the Apache Airflow project.
@dstandish dstandish added the kind:meta High-level information important to the community label Sep 22, 2022
dstandish added a commit to astronomer/airflow that referenced this issue Sep 22, 2022
@dstandish
Resolve warning about DISTINCT ON query on dags view
5e5b931 
Closes apache#26607
@dstandish dstandish mentioned this issue Sep 22, 2022
Merged
potiuk pushed a commit that referenced this issue Sep 23, 2022
@dstandish
Resolve warning about DISTINCT ON query on dags view (#26608)
55d1146 
Closes #26607
jedcunningham pushed a commit that referenced this issue Sep 26, 2022
@dstandish @jedcunningham
Resolve warning about DISTINCT ON query on dags view (#26608)
e436cb9 
Closes #26607

(cherry picked from commit 55d1146)
jedcunningham pushed a commit that referenced this issue Sep 27, 2022
@dstandish @jedcunningham
Resolve warning about DISTINCT ON query on dags view (#26608)
ef400fe 
Closes #26607

(cherry picked from commit 55d1146)
@jedcunningham jedcunningham mentioned this issue Sep 27, 2022
Closed
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:meta High-level information important to the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Resolve warning about DISTINCT ON query on dags view astronomer/airflow
1 participant
@dstandish