Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt Cloud Provider Not Compatible with emea.dbt.com #27146

Closed
2 tasks done
ernestoongaro opened this issue Oct 19, 2022 · 8 comments · Fixed by #28890
Closed
2 tasks done

dbt Cloud Provider Not Compatible with emea.dbt.com #27146

ernestoongaro opened this issue Oct 19, 2022 · 8 comments · Fixed by #28890
Assignees

Comments

@ernestoongaro
Copy link

Apache Airflow Provider(s)

dbt-cloud

Versions of Apache Airflow Providers

No response

Apache Airflow version

2.3.3

Operating System

Linux

Deployment

Composer

Deployment details

No response

What happened

Trying to use the provider with dbt Cloud's new EMEA region (https://docs.getdbt.com/docs/deploy/regions) but not able to use the emea.dbt.com as a tenant, as it automatically adds .getdbt.com to the tenant

What you think should happen instead

We should be able to change the entire URL - and it could still default to cloud.getdbt.com

How to reproduce

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@ernestoongaro ernestoongaro added area:providers kind:bug This is a clearly a bug labels Oct 19, 2022
@o-nikolas
Copy link
Contributor

Hey @ernestoongaro

Thanks for submitting this issue! It looks like you've checked that you're willing to submit a PR, that would be much appreciated! Would you like me to assign this task to you?

@josh-fell josh-fell self-assigned this Jan 11, 2023
@josh-fell
Copy link
Contributor

@o-nikolas I can take this.

@o-nikolas
Copy link
Contributor

@o-nikolas I can take this.

Thanks Josh!

josh-fell added a commit to josh-fell/airflow that referenced this issue Jan 12, 2023
Closes: apache#27146

Currently users can connect to both single-tenant and multi-tenant instances of dbt Cloud. However, for the enterprise tier, there is a new region offered as well as private instance support. The existing `tenant` value does not cover the ability to modify the entire domain name which could be required for users on the enterprise plan.

This enhancement allows users to specify the tenant domain they wish to connect to while keeping the "cloud.getdbt.com" domain as the default. Additionally, backward compat is implemented for those who are only specifying the third-level domain for single-tenant instances and wish to upgrade the provider version.
potiuk pushed a commit that referenced this issue Jan 12, 2023
Closes: #27146

Currently users can connect to both single-tenant and multi-tenant instances of dbt Cloud. However, for the enterprise tier, there is a new region offered as well as private instance support. The existing `tenant` value does not cover the ability to modify the entire domain name which could be required for users on the enterprise plan.

This enhancement allows users to specify the tenant domain they wish to connect to while keeping the "cloud.getdbt.com" domain as the default. Additionally, backward compat is implemented for those who are only specifying the third-level domain for single-tenant instances and wish to upgrade the provider version.
josh-fell added a commit to josh-fell/astronomer-providers that referenced this issue Jan 23, 2023
Related: apache/airflow#27146 apache/airflow#28890

In OSS Airflow, the dbt Cloud connection has replaced `schema` for `host` to provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.
phanikumv pushed a commit to astronomer/astronomer-providers that referenced this issue Jan 24, 2023
Related: apache/airflow#27146 apache/airflow#28890

In OSS Airflow, the dbt Cloud connection has replaced `schema` for `host` to provide the "tenant" name. This fix was included in the latest version of the dbt Cloud provider (2.3.1) and should also be reflected in this provider.
@erdinculuturk-nw
Copy link

hey all @josh-fell @ernestoongaro,

Looks like this fix hasn't been released yet.
Is there any workaround that I can use until the release?

Thanks,
Erdinc

@josh-fell
Copy link
Contributor

@erdinculuturk-nw The fix was released as part of version 2.3.1 of the dbt Cloud provider package. What version of the provider package do you have installed?

@erdinculuturk-nw
Copy link

Hey @josh-fell, thanks for the quick reply.
Now I found it is 2.2.0 for us.

@josh-fell
Copy link
Contributor

Right on, if you still can't connect to the EMEA region with 2.3.1+, let us know.

@erdinculuturk-nw
Copy link

hey @josh-fell, just wanted to let you know that it works fine now after upgrading to proper versions for both Airflow and dbt Cloud provider.
Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants