Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Status of testing of Apache Airflow Helm Chart 1.10.0rc1 #32096

Closed
6 of 15 tasks
jedcunningham opened this issue Jun 23, 2023 · 9 comments
Closed
6 of 15 tasks

Status of testing of Apache Airflow Helm Chart 1.10.0rc1 #32096

jedcunningham opened this issue Jun 23, 2023 · 9 comments
Labels
kind:meta High-level information important to the community testing status Status of testing releases

Comments

@jedcunningham
Copy link
Member

jedcunningham commented Jun 23, 2023

We are kindly requesting that contributors to Apache Airflow Helm Chart 1.10.0rc1 help test the RC.

Please let us know by commenting if the issue is addressed in the latest RC.

Thanks to all who contributed to the release (probably not a complete list!):
@potiuk @ephraimbuddy @wookiist @dzhigimont @hussein-awala @mikaeld @nirroz93 @eladkal @grjones @jedcunningham @TarunParimi @NipunaPrashan @Aakcht @dnskr

@jedcunningham jedcunningham added the kind:meta High-level information important to the community label Jun 23, 2023
@Aakcht
Copy link
Contributor

Aakcht commented Jun 23, 2023

Tested #31865 - all good.

As for #30990 looks like it got mixed up with #30773 and the extraVolumeMounts of dagprocessor wait for migrations init container are not templated and extraVolumeMounts of other containers are templated. I added a PR to fix this: #32100

@eladkal eladkal added the testing status Status of testing releases label Jun 23, 2023
@pankajkoti
Copy link
Member

I am wondering if we want to include #30963 here as the PR has an associated milestone of 2.7.0

If we want to include it here, I have a question next. When I deploy the helm chart from this RC, it runs fine and example DAGs are running fine. But when I exec into pods, and enter python shell it uses Python3.7, also example DAGs with Python operator seem to use Python3.7. What should be the expected Python version here?

@potiuk
Copy link
Member

potiuk commented Jun 23, 2023

I am wondering if we want to include #30963 here as the PR has an associated milestone of 2.7.0

Python version is connected with Airflow version. It's not "chart" property it's actually "image" property. And according to our agreed policies, default versio of Airflow supported in 2.6 is 3.7.

From: https://github.com/apache/airflow/blob/main/README.md#support-for-python-and-kubernetes-versions

We drop support for Python and Kubernetes versions when they reach EOL. Except for Kubernetes, a version stays supported by Airflow if two major cloud providers still provide support for it. We drop support for those EOL versions in main right after EOL date, and it is effectively removed when we release the first new MINOR (Or MAJOR if there is no new MINOR version) of Airflow. For example, for Python 3.8 it means that we will drop support in main right after 27.06.2023, and the first MAJOR or MINOR version of Airflow released after will not have it.

I think there is a one mistake in README regarding 2.6.2 image after we bumped version numbers (I will fix it in a moment) but intention was that 3.7 will remain default and released version for all 2.6* airflow/image versions. The 3.8 will become default/minimum version supported when we release 2.7.0.

@potiuk
Copy link
Member

potiuk commented Jun 23, 2023

#32103 -> to remove the confusing paragraph.

@dnskr
Copy link
Contributor

dnskr commented Jun 23, 2023

@potiuk
Copy link
Member

potiuk commented Jun 23, 2023

BTW @pankajkoti clarifying comment:

The reason why the PR to remove support was included in the list was this https://github.com/apache/airflow/pull/30963/files#diff-b3ffb75587232c802c4c65d8d27f30a07f72e1819e3a695ca5758d727bde3b31L2079

"description": "Enable triggerer (requires Python 3.7+).",-> "description": "Enable triggerer",

And well - this was actually an overdue change. This should have been removed already when we got rid of airflow 3.6 - I just removed it while removing python 3.7, because I looked for all the 3.7 occurences. So even if "Remove Python 3.7" support was part of the PRs in the chart, the actual removal of Python 3.7 had nothing to do with the chart

@potiuk
Copy link
Member

potiuk commented Jun 23, 2023

Looks good !

@pankajkoti
Copy link
Member

Thank you for clarifying in detail @potiuk and the quick fix. Yes, was wondering intially if the image itself needed some fix, but all clear now.

@jedcunningham
Copy link
Member Author

1.10.0 is (almost) out! Thanks everyone for taking the time to test the RC!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:meta High-level information important to the community testing status Status of testing releases
Projects
None yet
Development

No branches or pull requests

6 participants