-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(chart): add container security context #31043
feat(chart): add container security context #31043
Conversation
I've fixed most of the unit test issues in @potiuk @jedcunningham @ChrisFraun Thanks! |
bd3c365
to
23c7961
Compare
I rebased it to latest main to check if it was not a temporary issue but if it does not help, I think the only way is to follow the exact steps in https://github.com/apache/airflow/blob/main/TESTING.rst#helm-unit-tests and see if it can be reproduced (including rebuilding the latest image) - this will run the tests in the same conditions as they are run in CI and you can also enter breeze image and run the tests from there - looks like for some reason, trying to render those helm templates failed, but what was the reason is hard to say until you manually run the exact It can also be (though not very likely) that this is a side effect of runnning the tests one after another and then the reason for the side effects should be investigated. |
Co-authored-by: Christoph Fraundorfer <christoph.fraundorfer@allianzdirect.de> Co-authored-by: ChrisFraun <85613395+ChrisFraun@users.noreply.github.com> Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
0c21962
to
b8aff05
Compare
@potiuk I've fixed the tests! |
great. I think some comments on that from a few people involved in chart more than me would be great, let's wait for them - now that the tests are green it;s good for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jedcunningham @dstandish @ephraimbuddy - it seems like a good change - do you see some problems with it?
@jedcunningham Thanks for the feedback, I've addressed the issues. This is ready for re-review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last round 🤞
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
@jedcunningham ready for review! |
#protm Thanks @ChrisFraun and @mikaeld! Really appreciate all the effort and persistence to get this change in 🍺 |
This is a follow up to #24588 which was closed due to a fork sync'ing issue. From the original PR by @ChrisFraun:
closes: #27612
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.