Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearing task from List Task Instance page in UI does not also clear downstream tasks? #33014

Closed
1 of 2 tasks
aamster opened this issue Aug 1, 2023 · 9 comments · Fixed by #34529
Closed
1 of 2 tasks
Assignees
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests priority:low Bug with a simple workaround that would not block a release

Comments

@aamster
Copy link

aamster commented Aug 1, 2023

Apache Airflow version

2.6.3

What happened

Select tasks from List Task Instance page in UI and select clear
Only those tasks are cleared and downsteam tasks are not also cleared as they are in the DAG graph view

What you think should happen instead

downstream tasks should also be cleared

How to reproduce

Select tasks from List Task Instance page in UI for which there are downstream tasks and select clear

Operating System

rocky

Versions of Apache Airflow Providers

No response

Deployment

Official Apache Airflow Helm Chart

Deployment details

No response

Anything else

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@aamster aamster added area:core kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Aug 1, 2023
@RNHTTR RNHTTR added kind:feature Feature Requests good first issue priority:low Bug with a simple workaround that would not block a release and removed kind:bug This is a clearly a bug needs-triage label for new issues that we didn't triage yet labels Aug 1, 2023
@RNHTTR
Copy link
Collaborator

RNHTTR commented Aug 1, 2023

I think instead of automatically also clearing downstream tasks, maybe the modal from the grid/graph view should be displayed, giving the user the choice. For example:

image

@pankajkoti pankajkoti added area:UI Related to UI/UX. For Frontend Developers. and removed area:core labels Aug 2, 2023
@pankajkoti
Copy link
Member

@RNHTTR I removed the area:core label and put it area:UI. Please check if it sounds right.

@pankajkoti
Copy link
Member

pankajkoti commented Aug 2, 2023

I think that would be the ideal way though. It should not silently clear all the downstream tasks unless explicitly asked for.

I think we could discuss if it's a good idea to display the modal view from the List view.

cc: @bbovenzi @pierrejeambrun @Adaverse

@bbovenzi
Copy link
Contributor

bbovenzi commented Aug 2, 2023

Let's at least update this confirmation text to say that it includes downstream tasks?

From:
Screenshot 2023-08-02 at 2 44 48 PM

To:
Screenshot 2023-08-02 at 2 46 10 PM

@Adaverse
Copy link
Contributor

Adaverse commented Aug 2, 2023

I think that would be the ideal way though. It should not silently clear all the downstream tasks unless explicitly asked for.

I think we could discuss if it's a good idea to display the modal view from the List view.

Yes, this would be ideal. Not sure if we can reuse the same components unless we migrate this above screen to React?

@bbovenzi
Copy link
Contributor

bbovenzi commented Aug 2, 2023

Yes, replacing this in react is a lot for now. let's at least update the confirmation modal since that already exists on the FAB model.

@aamster
Copy link
Author

aamster commented Aug 15, 2023

I would consider this a bug, not a new feature. I should never be uncertain what airflow is going to do. Here the obvious thing I would expect is that downstream tasks would be cleared like they are in other parts of the UI. It is common to need to resubmit groups of tasks and have downstream tasks automatically retriggered, but this does not happen. It is disoncerting that I have to constantly check to make sure airflow is functioning the way I expect for key business needs such as retriggering groups of tasks which it does not in this case.

@peloyeje
Copy link
Contributor

Hey, I would like to try this one if that's ok
To make sure I get it right, expected behavior would be that downstream TIs are cleared + modal explicitely warns about it right?

@pierrejeambrun
Copy link
Member

pierrejeambrun commented Sep 20, 2023

@peloyeje yep, just assigned you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. good first issue kind:feature Feature Requests priority:low Bug with a simple workaround that would not block a release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants