New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to clear downstream tis in "List Task Instances" view #34529
Add ability to clear downstream tis in "List Task Instances" view #34529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
3977962
to
4ad02d1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, looking nice
ca8cfaa
to
9e5a466
Compare
Just pushed yet another tweaks to the initial implementation so that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! LGTM
task_id for task_id in partial_dag.task_dict if task_id not in task_ids_to_clear | ||
] | ||
|
||
# dag.clear returns TIs when in dry run mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
Congrats Jean-Eudes on your first commit 🎉 |
Thanks everyone for your feedback! |
Adds a new "clear (including downstream)" action in the "List Task Instances" view
Also a bit of refactoring so that "clear" / "clear including downstream" share the same logic
Added a unit test to make sure clearing logic is "run-aware"
closes: #33014
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rst
or{issue_number}.significant.rst
, in newsfragments.