Fix updating variables during variable imports #33932
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ephraimbuddy
requested review from
ryanahamilton,
ashb,
bbovenzi and
pierrejeambrun
as code owners
uranusjr
reviewed
Aug 31, 2023
uranusjr
reviewed
Aug 31, 2023
uranusjr
reviewed
Aug 31, 2023
|
I think we should a flag specifying that behaviour. I think the flag should be something of (probably too long name): IMHO override shoudl remain as it is (default), as it could break existing usages. |
ephraimbuddy
force-pushed
the
dont-override-variables-during-import
branch
from
2738fc5
to
2718f6f
Compare
Implemented this also in the UI with radios: I can't think of a better name than the one you suggested. |
ephraimbuddy
force-pushed
the
dont-override-variables-during-import
branch
from
2718f6f
to
7c6080b
Compare
potiuk
approved these changes
Aug 31, 2023
uranusjr
reviewed
Sep 1, 2023
uranusjr
reviewed
Sep 1, 2023
ephraimbuddy
force-pushed
the
dont-override-variables-during-import
branch
from
7c6080b
to
161e822
Compare
uranusjr
reviewed
Sep 1, 2023
uranusjr
reviewed
Sep 1, 2023
We should only create new variables during variable imports and not update already existing variables.
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
Co-authored-by: Tzu-ping Chung <uranusjr@gmail.com>
ephraimbuddy
force-pushed
the
dont-override-variables-during-import
branch
from
3e29b65
to
91fd57d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should only create new variables during variable imports and not update already existing variables.