Fix py/url-redirection by replacing request.referrer by get_redirect() #34237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hussein-awala
requested review from
potiuk,
ephraimbuddy,
pierrejeambrun and
eladkal
hussein-awala
requested review from
ryanahamilton,
ashb and
bbovenzi
as code owners
|
Does this also need to call |
Yep. I thinl it should, otherwise back/resubmit button wil skip over it. |
uranusjr
approved these changes
Sep 14, 2023
Taragolis
approved these changes
Sep 18, 2023
pierrejeambrun
approved these changes
Sep 22, 2023
|
Changed milestone to 2.7.2, this is security related and can be released as bugfix I believe asap. |
|
I used the same milestone as #33932 because the change is not released yet. But it looks like the other PR is a bug-fix too. |
|
Oh I see, I believe 33932 started as a bug fix but ended up adding new options and is now more of an ‘improvement’. Putting back 2.8.0, sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
redirect(location=request.referrer)is not safe, and we don't use it in the webserver, instead we useBaseView.get_redirect()to get the original the previous url.Is there any specific reason to use request.referrer in #33932? (I don't think so)
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.