Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a pattern-matching support for allow and block list in Datadog metric #39368

Closed
2 tasks done
rawwar opened this issue May 2, 2024 · 0 comments · Fixed by #39370
Closed
2 tasks done

Add a pattern-matching support for allow and block list in Datadog metric #39368

rawwar opened this issue May 2, 2024 · 0 comments · Fixed by #39370
Labels
kind:feature Feature Requests provider:datadog

Comments

@rawwar
Copy link
Contributor

rawwar commented May 2, 2024

Description

Currently, when exporting metrics to Datadog, we only do plain prefix matches for the allow list and block list. I am requesting to include regex pattern-matching

Use case/motivation

We are already supporting this for OTEL #36250. Adding this to Datadog will help to maintain a reduced number of patterns required in the allow/block list

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@rawwar rawwar added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 2, 2024
@rawwar rawwar mentioned this issue May 2, 2024
Merged
@RNHTTR RNHTTR added provider:datadog and removed needs-triage label for new issues that we didn't triage yet labels May 2, 2024
pankajkoti pushed a commit that referenced this issue May 6, 2024
@rawwar
Refactor SafeDogStatsdLogger to use get_validator to enable patte…
0c4ffb8 
…rn matching (#39370)

closes #39368

By reusing the get_validators function, we can incorporate pattern search to include allow/block lists.
RodrigoGanancia pushed a commit to RodrigoGanancia/airflow that referenced this issue May 10, 2024
@rawwar @RodrigoGanancia
Refactor SafeDogStatsdLogger to use get_validator to enable patte…
19e8b0f 
…rn matching (apache#39370)

closes apache#39368

By reusing the get_validators function, we can incorporate pattern search to include allow/block lists.
pateash pushed a commit to pateash/airflow that referenced this issue May 13, 2024
@rawwar @pateash
Refactor SafeDogStatsdLogger to use get_validator to enable patte…
e9d1cdf 
…rn matching (apache#39370)

closes apache#39368

By reusing the get_validators function, we can incorporate pattern search to include allow/block lists.
ephraimbuddy pushed a commit that referenced this issue Jun 4, 2024
@rawwar @ephraimbuddy
Refactor SafeDogStatsdLogger to use get_validator to enable patte…
2d88cca 
…rn matching (#39370)

closes #39368

By reusing the get_validators function, we can incorporate pattern search to include allow/block lists.

(cherry picked from commit 0c4ffb8)
@utkarsharma2 utkarsharma2 mentioned this issue Jun 6, 2024
Closed
41 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind:feature Feature Requests provider:datadog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor SafeDogStatsdLogger to use get_validator to enable pattern matching rawwar/airflow
2 participants
@rawwar @RNHTTR