Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Support for GitHub App Installation Authentication in GithubHook #39457

Open
2 tasks done
kesugano opened this issue May 7, 2024 · 1 comment
Open
2 tasks done

Add Support for GitHub App Installation Authentication in GithubHook #39457

kesugano opened this issue May 7, 2024 · 1 comment
Assignees
@kesugano
Labels
area:providers kind:feature Feature Requests provider:github

Comments

@kesugano
Copy link

kesugano commented May 7, 2024

Description

Enhance the GithubHook to support GitHub App installation authentication.

While the hook currently supports only token-based authentication, adding support for GitHub App installation authentication will provide a more secure option for Airflow users interacting with GitHub.

Use case/motivation

GitHub App installation authentication offers a more secure and granular permission model compared to personal access tokens. It allows for better audit trails and security practices, which are crucial for organizations managing complex workflows on GitHub.

By integrating this authentication method into GithubHook, Airflow users can leverage the benefits of GitHub Apps, such as fine-grained permissions, enhanced security, and improved automation capabilities within their data pipelines.

Related issues

No response

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct
@kesugano kesugano added kind:feature Feature Requests needs-triage label for new issues that we didn't triage yet labels May 7, 2024
@boring-cyborg boring-cyborg
Copy link

boring-cyborg bot commented May 7, 2024

Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.

@Lee-W Lee-W added provider:github area:providers and removed needs-triage label for new issues that we didn't triage yet labels May 7, 2024
kesugano added a commit to kesugano/airflow that referenced this issue May 8, 2024
@kesugano
Add support for GitHub App Installation Authentication method
71dfe11 
- Implement support for GitHub App Installation Authentication, enhancing security and flexibility for GitHub interactions.
- Upgrade `PyGithub` dependency to version 1.59.0 or higher to utilize the new `github.Auth` module, necessary for the new authentication method.

This change introduces support for the GitHub App Installation Authentication method, addressing the need for more secure and versatile authentication options in Airflow's GitHub integration.

Related issue: apache#39457
kesugano added a commit to kesugano/airflow that referenced this issue May 8, 2024
@kesugano
Add support for GitHub App Installation Authentication method
ee3e1e4 
- Implement support for GitHub App Installation Authentication, enhancing security and flexibility for GitHub interactions.
- Upgrade `PyGithub` dependency to version 1.59.0 or higher to utilize the new `github.Auth` module, necessary for the new authentication method.

This change introduces support for the GitHub App Installation Authentication method, addressing the need for more secure and versatile authentication options in Airflow's GitHub integration.

Related issue: apache#39457
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kesugano kesugano

Labels
area:providers kind:feature Feature Requests provider:github
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Lee-W @kesugano