Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SalesforceHook missing method to return dataframe #8565

Closed
jeffolsi opened this issue Apr 26, 2020 · 4 comments
Closed

SalesforceHook missing method to return dataframe #8565

jeffolsi opened this issue Apr 26, 2020 · 4 comments
Labels
good first issue kind:feature Feature Requests

Comments

@jeffolsi
Copy link

Currently SalesforceHook has function write_object_to_file which query salesforce and save the output to file. On the way it also uses df. The function even return the df.
the problem is that if someone wants only df he must also provide file_name which can't be empty! and set fmt=None this doesn't really work well and it causes troubles.

The function write_object_to_file should be divided to object_to_df which returns df and then the write_object_to_file can uses object_to_df as the first step before exporting to file.
@jeffolsi jeffolsi added the kind:feature Feature Requests label Apr 26, 2020
@VinodKumarLogan
Copy link

Hi @jeffolsi @potiuk , can I give this a shot and submit a PR?

@jeffolsi
Copy link
Author

@VinodKumarLogan sure

@pranjalmittal pranjalmittal mentioned this issue Apr 30, 2020
Merged
6 tasks
@pranjalmittal
Copy link
Contributor

Created a PR for the issue: #8644

potiuk pushed a commit that referenced this issue May 17, 2020
@pranjalmittal
Added SalesforceHook missing method to return only dataframe (#8565) (#…
ff342fc 
…8644)

* add feature for skipping writing to file

* add SalesforceHook missing method to return dataframe only

function write_object_to_file is divided to object_to_df which returns df and then the write_object_to_file can uses object_to_df as the first step before exporting to file

* fixed exception message

* fix review comments - removed filename check for None
@jeffolsi
Copy link
Author

fixed in #8644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue kind:feature Feature Requests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@potiuk @VinodKumarLogan @pranjalmittal @jeffolsi