Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Info about the parameter "conf" when triggering a DAG #8900

Closed
AmarEL opened this issue May 18, 2020 · 4 comments · Fixed by #9578
Closed

Info about the parameter "conf" when triggering a DAG #8900

AmarEL opened this issue May 18, 2020 · 4 comments · Fixed by #9578
Assignees
Labels

Comments

@AmarEL
Copy link
Contributor

AmarEL commented May 18, 2020

Description

The information and examples about the optional JSON conf when triggering a dag from UI or by CLI needs to be included in the documentation.

Use case / motivation

I would like to have some reference in Docs since conf is not even mentioned as a parameter in the create_dagrun method in the specification of parameters. I would like to have too some examples of how to use conf in a DAG definition code since there is no section for that yet and some people, like me, would be missing this information about how to access this parameter.

    @provide_session
    def create_dagrun(self,
                      run_id,
                      state,
                      execution_date=None,
                      start_date=None,
                      external_trigger=False,
                      conf=None,
                      session=None):
        """
        Creates a dag run from this dag including the tasks associated with this dag.
        Returns the dag run.
        :param run_id: defines the run id for this dag run
        :type run_id: str
        :param execution_date: the execution date of this dag run
        :type execution_date: datetime.datetime
        :param state: the state of the dag run
        :type state: airflow.utils.state.State
        :param start_date: the date this dag run should be evaluated
        :type start_date: datetime
        :param external_trigger: whether this dag run is externally triggered
        :type external_trigger: bool
        :param session: database session
        :type session: sqlalchemy.orm.session.Session
        """

Related Issues

#7312

@AmarEL AmarEL added the kind:feature Feature Requests label May 18, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented May 18, 2020

Thanks for opening your first issue here! Be sure to follow the issue template!

@mik-laj
Copy link
Member

mik-laj commented Jun 7, 2020

@AmarEL
Copy link
Contributor Author

AmarEL commented Jun 7, 2020

That works!
But I think that adding the param conf and its type in the create_dagrun docstring would be more complete, because the create_dagrun method doesn't have this param in the docstring.

@kaxil kaxil self-assigned this Jun 11, 2020
@kaxil kaxil added this to the Airflow 1.10.11 milestone Jun 11, 2020
@kaxil
Copy link
Member

kaxil commented Jun 11, 2020

Related issue I had created: #9238 (comment) -will add some more docs for 1.10.11

kaxil added a commit to astronomer/airflow that referenced this issue Jun 29, 2020
kaxil added a commit that referenced this issue Jun 29, 2020
kaxil added a commit that referenced this issue Jul 1, 2020
closes #8900

(cherry picked from commit ce4c229)
kaxil added a commit that referenced this issue Jul 1, 2020
closes #8900

(cherry picked from commit ce4c229)
kaxil added a commit that referenced this issue Jul 1, 2020
closes #8900

(cherry picked from commit ce4c229)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this issue Mar 5, 2021
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 4, 2021
closes apache/airflow#8900

(cherry picked from commit ce4c2297c6c30ccae4222633b923e1a1cda98ec6)

GitOrigin-RevId: 641e1106495050f185265c6e3460758def80734a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 4, 2021
closes apache/airflow#8900

(cherry picked from commit ce4c2297c6c30ccae4222633b923e1a1cda98ec6)

GitOrigin-RevId: 641e1106495050f185265c6e3460758def80734a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 9, 2021
closes apache/airflow#8900

(cherry picked from commit ce4c2297c6c30ccae4222633b923e1a1cda98ec6)

GitOrigin-RevId: 641e1106495050f185265c6e3460758def80734a
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 15, 2021
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 17, 2021
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Sep 23, 2021
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Nov 25, 2021
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Mar 9, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 3, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jun 6, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jul 8, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Aug 27, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 4, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Oct 7, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Dec 7, 2022
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this issue Jan 27, 2023
closes apache/airflow#8900

GitOrigin-RevId: ce4c2297c6c30ccae4222633b923e1a1cda98ec6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants