Use Hash of Serialized DAG to determine DAG is changed or not #10227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaxil
force-pushed
the
dag-s10n-optimization
branch
from
935a138
to
a000450
Compare
|
Ping @potiuk |
potiuk
requested changes
Aug 9, 2020
airflow/models/serialized_dag.py
Outdated
| @@ -65,6 +66,11 @@ class SerializedDagModel(Base): | |||
| fileloc_hash = Column(BigInteger, nullable=False) | |||
| data = Column(sqlalchemy_jsonfield.JSONField(json=json), nullable=False) | |||
| last_updated = Column(UtcDateTime, nullable=False) | |||
| # TODO: Make dag_hash not nullable in Airflow 1.10.13 or Airflow 2.0?? | |||
There was a problem hiding this comment.
We can make it not nullable and add default value in the migration ("Hash not calculated yet"). This way it will be refreshed with the next run automagically and we will not worry about nullability.
There was a problem hiding this comment.
Good point. I was tempted to do that, the only reason I didn't do it was to avoid any impression that it is a hash but I think that might not be a problem.
airflow/models/serialized_dag.py
Outdated
| serialized_dag_hash_from_db = session.query( | ||
| cls.dag_hash).filter(cls.dag_id == dag.dag_id).scalar() | ||
|
|
||
| if serialized_dag_hash_from_db and (serialized_dag_hash_from_db == new_serialized_dag.dag_hash): |
There was a problem hiding this comment.
If make the column nullable with default this might be just ==
kaxil
force-pushed
the
dag-s10n-optimization
branch
from
1287765
to
de3f184
Compare
potiuk
approved these changes
Aug 11, 2020
|
🎉 👍 |
kaxil
added a commit
that referenced
this pull request
Aug 13, 2020
kaxil
added a commit
that referenced
this pull request
Aug 15, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…#10227) closes apache#10116 (cherry picked from commit adce6f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #10116
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.