Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix support for asctime field in JSON formatted logs #10515

Merged
merged 1 commit into from Sep 16, 2020

Conversation

rgrizzell
Copy link
Contributor

@rgrizzell rgrizzell commented Aug 24, 2020

The JSON Formatter utilized by the Elasticsearch provider did not generate a timestamp for the asctime field when it was included in the json_fields configuration option. This pull request addresses that issue by defining a function that supersedes the usesTime fuction in the logging.Formatter superclass.

closes: #10024

@boring-cyborg
Copy link

boring-cyborg bot commented Aug 24, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://apache-airflow-slack.herokuapp.com/

@rgrizzell rgrizzell force-pushed the master branch 2 times, most recently from 1f325e7 to 95cb523 Compare August 31, 2020 15:27
@ashb ashb merged commit 2aec99c into apache:master Sep 16, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Sep 16, 2020

Awesome work, congrats on your first merged pull request!

kaxil pushed a commit to astronomer/airflow that referenced this pull request Nov 21, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Nov 25, 2020
(cherry picked from commit 2aec99c)
(cherry picked from commit 376e8c4)
kaxil pushed a commit to astronomer/airflow that referenced this pull request Nov 27, 2020
@kaxil kaxil added this to the Airflow 1.10.14 milestone Dec 1, 2020
kaxil pushed a commit that referenced this pull request Dec 1, 2020
kaxil pushed a commit that referenced this pull request Dec 3, 2020
ashb pushed a commit that referenced this pull request Dec 3, 2020
kaxil pushed a commit to astronomer/airflow that referenced this pull request Dec 10, 2020
(cherry picked from commit 2aec99c)
(cherry picked from commit 21a9bd0)
AntonyRileyAtVerto pushed a commit to vertoanalytics/incubator-airflow that referenced this pull request Feb 2, 2021
- BugFix: Tasks with ``depends_on_past`` or ``task_concurrency`` are stuck (apache#12663)
- Fix issue with empty Resources in executor_config (apache#12633)
- Fix: Deprecated config ``force_log_out_after`` was not used (apache#12661)
- Fix empty asctime field in JSON formatted logs (apache#10515)
- [AIRFLOW-2809] Fix security issue regarding Flask SECRET_KEY (apache#3651)
- [AIRFLOW-2884] Fix Flask SECRET_KEY security issue in www_rbac (apache#3729)
- [AIRFLOW-2886] Generate random Flask SECRET_KEY in default config (apache#3738)
- Add missing comma in setup.py (apache#12790)
- Bugfix: Unable to import Airflow plugins on Python 3.8 (apache#12859)
- Fix setup.py missing comma in ``setup_requires`` (apache#12880)
- Don't emit first_task_scheduling_delay metric for only-once dags (apache#12835)

- Update setup.py to get non-conflicting set of dependencies (apache#12636)
- Rename ``[scheduler] max_threads`` to ``[scheduler] parsing_processes`` (apache#12605)
- Add metric for scheduling delay between first run task & expected start time (apache#9544)
- Add new-style 2.0 command names for Airflow 1.10.x (apache#12725)
- Add Kubernetes cleanup-pods CLI command for Helm Chart (apache#11802)
- Don't let webserver run with dangerous config (apache#12747)
- Replace pkg_resources with importlib.metadata to avoid VersionConflict errors (apache#12694)

- Clarified information about supported Databases
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Writing Logs to Elasticsearch: asctime field in JSON log output set to null
3 participants