New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make grace_period_seconds option on K8sPodOperator #10727
Merged
dimberman
merged 2 commits into
apache:master
from
astronomer:fix_kubernetes_pod_operator_on_kill
Sep 4, 2020
Merged
Make grace_period_seconds option on K8sPodOperator #10727
dimberman
merged 2 commits into
apache:master
from
astronomer:fix_kubernetes_pod_operator_on_kill
Sep 4, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them.
kaxil
reviewed
Sep 4, 2020
Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
ashb
approved these changes
Sep 4, 2020
kaxil
reviewed
Sep 4, 2020
kaxil
approved these changes
Sep 4, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 minor suggestion or else LGTM
dimberman
added a commit
that referenced
this pull request
Sep 16, 2020
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
pushed a commit
to astronomer/airflow
that referenced
this pull request
Sep 17, 2020
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> (cherry picked from commit 6b86255)
RaviTezu
pushed a commit
to RaviTezu/airflow
that referenced
this pull request
Oct 25, 2020
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added a commit
that referenced
this pull request
Nov 12, 2020
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
potiuk
pushed a commit
that referenced
this pull request
Nov 16, 2020
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
kaxil
added
provider:cncf-kubernetes
Kubernetes provider related issues
and removed
area:k8s
labels
Nov 18, 2020
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
* Make grace_period_seconds option on K8sPodOperator This PR allows users to choose whether they want to gracefully kill pods when they delete tasks in the UI or if they would like to immediately kill them. * Update airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com> Co-authored-by: Kaxil Naik <kaxilnaik@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
provider:cncf-kubernetes
Kubernetes provider related issues
type:improvement
Changelog: Improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows users to choose whether they want to gracefully kill
pods when they delete tasks in the UI or if they would like to
immediately kill them.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.