Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the usage of bash 'shift' consistent across Breeze #10907

Merged
merged 1 commit into from
Sep 13, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 13, 2020

If an argument is not provided to shift it by default uses shift 1. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from potiuk September 13, 2020 01:15
@kaxil kaxil changed the title Make the usage of shift consistent across Airflow Make the usage of bash 'shift' consistent across Breeze Sep 13, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice :)

@potiuk potiuk merged commit 75bbddf into apache:master Sep 13, 2020
@kaxil kaxil deleted the use-shift-consistently branch September 13, 2020 14:53
potiuk pushed a commit to potiuk/airflow that referenced this pull request Sep 14, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
potiuk pushed a commit that referenced this pull request Sep 15, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
RaviTezu pushed a commit to RaviTezu/airflow that referenced this pull request Oct 25, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
kaxil added a commit that referenced this pull request Nov 12, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
@potiuk potiuk added this to the Airflow 1.10.13 milestone Nov 14, 2020
@potiuk potiuk added the type:misc/internal Changelog: Misc changes that should appear in change log label Nov 14, 2020
potiuk pushed a commit that referenced this pull request Nov 16, 2020
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
cfei18 pushed a commit to cfei18/incubator-airflow that referenced this pull request Mar 5, 2021
If an argument is not provided to `shift` it by default uses `shift 1`. The commands "shift 1" and "shift" (with no argument) do the same thing. This PR makes the usage consistent as there were occurences of both

(cherry picked from commit 75bbddf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:dev-tools type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants