Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get Airflow configs with sensitive data from AWS Systems Manager #11023

Merged
merged 1 commit into from
Sep 19, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 19, 2020

Adds support to AWS SSM for feature added in #9645


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil requested a review from potiuk September 19, 2020 01:35
@boring-cyborg boring-cyborg bot added area:secrets provider:amazon-aws AWS/Amazon - related issues labels Sep 19, 2020
Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Will that work however before secret backend is initialized? It is initialised in config, so just wondering if there is no "chicken-egg" problem here.

@kaxil kaxil merged commit 2410f59 into apache:master Sep 19, 2020
@kaxil kaxil deleted the aws-ssm-config branch September 19, 2020 18:05
@kaxil
Copy link
Member Author

kaxil commented Sep 19, 2020

Nice. Will that work however before secret backend is initialized? It is initialised in config, so just wondering if there is no "chicken-egg" problem here.

Yup it will continue to work. _get_config_value_from_secret_backend will be called which will take care of initialization too :)

def _get_config_value_from_secret_backend(config_key):
"""Get Config option values from Secret Backend"""
secrets_client = get_custom_secret_backend()
if not secrets_client:
return None
return secrets_client.get_config(config_key)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:secrets provider:amazon-aws AWS/Amazon - related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants