Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Edit Button from DagModel View #11026

Merged
merged 1 commit into from Sep 19, 2020

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Sep 19, 2020

We don't allow Editing DagModel so it will fail with Permissions anyway so the button is useless.

Error:

[2020-09-18 14:42:15,160] {decorators.py:111} WARNING - Access is Denied for: can_edit on: DagModelView

Before
image

After:

image

closes: #11014


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil merged commit 78c3424 into apache:master Sep 19, 2020
@kaxil kaxil deleted the remove-dag-model-edit branch September 19, 2020 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:webserver Webserver related Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RBAC UI: Editing dag runs gives forbidden page when admin
2 participants