-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ImportChangesRule for upgrade check #11056
Add ImportChangesRule for upgrade check #11056
Conversation
429983a
to
24ccf6a
Compare
24ccf6a
to
f46c039
Compare
cc @vikramkoka |
This comment has been minimized.
This comment has been minimized.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
f46c039
to
4d48116
Compare
The docs faliure was already fixed. |
class ImportChange( | ||
NamedTuple( | ||
"ImportChange", | ||
[("old_path", str), ("new_path", str), ("providers_package", Optional[None])], | ||
) | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can be simplified
class ImportChange( | |
NamedTuple( | |
"ImportChange", | |
[("old_path", str), ("new_path", str), ("providers_package", Optional[None])], | |
) | |
): | |
class ImportChange(NamedTuple) | |
old_path: str | |
new_path: str | |
providers_package: Optional[None] | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh wait, I know why you did this, for compatibility with Py 2.7 , Py 3.5 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup, not a big fan of this but we this command has to work with 2.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some operators did the other way.. from providers to core
#10013
this message will be wrong for it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The message will be:
Using
airflow.operators.email_operator.EmailOperator
will be replaced byairflow.operators.email.EmailOperator
.
And I see no place for confusion here
bd4214b
to
195f00d
Compare
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Adds new rule that will be run during airflow upgrade-check and will look for old clasess and imports incompatible with Airflow 2.0.
Adds new rule that will be run during airflow upgrade-check
and will look for old clasess and imports incompatible with
Airflow 2.0.
Example:
Related to #8765
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.