Adding ChainBetwenDAGAndOperatorNotAllowedRule for easing upgrade to 2.0 #11839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
|
turbaszek
added
the
area:upgrade
turbaszek
reviewed
Oct 25, 2020
Comment on lines
59
to
60
| assert isinstance(rule.description, str) | ||
| assert isinstance(rule.title, str) |
There was a problem hiding this comment.
How about adding separate test for this instead of duplicating this in every test? 😉
There was a problem hiding this comment.
Thanks, sorry about the copypasta. Pushed a fix!
turbaszek
reviewed
Oct 25, 2020
| assert 0 == len(msgs) | ||
|
|
||
| def test_invalid_check(self, mock_list_files): | ||
| lines = ["dag = DAG('my_dag')", |
There was a problem hiding this comment.
Will it work if users do dag1 = DAG(..)?
There was a problem hiding this comment.
Yep, updated this test to demonstrate!
turbaszek
approved these changes
Oct 25, 2020
turbaszek
approved these changes
Oct 27, 2020
|
Awesome work, congrats on your first merged pull request! |
cfei18
pushed a commit
to cfei18/incubator-airflow
that referenced
this pull request
Mar 5, 2021
…2.0 (apache#11839) * Adding ChainBetwenDAGAndOperatorNotAllowedRule for checking upgrade to Airflow 2.0 (apache#11040) * Cleaning up tests for apache#11839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #11040
related: #8765
Thanks for reviewing and please let me know if I need to go about this a different way!