Fix QueuedLocalWorker crashing with EOFError #13215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalExecutor uses a multiprocessing.Queue to distribute tasks to the instances of QueuedLocalWorker. If for some reason LocalExecutor exits (e.g. because it encountered an unhandled exception), then each of the QueuedLocalWorker instances that it manages will also exit while trying to read from the task queue. This obfuscates the root cause of the issue, i.e. that the LocalExecutor terminated. By catching EOFError, logging an error and exiting gracefully we circumvent this issue.
ashb
approved these changes
Dec 21, 2020
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
full tests needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LocalExecutoruses a multiprocessing.Queue to distribute tasks to the instances ofQueuedLocalWorker. If for some reason LocalExecutor exits (e.g. because it encountered an unhandled exception), then each of the QueuedLocalWorker instances that it manages will also exit with an uncaughtEOFErrorwhile trying to read from the task queue.Because this causes a traceback to be logged for each of the workers that exits, this obfuscates the root cause of the issue, i.e. that the managing
LocalExecutorterminated. By catching theEOFErrorin QueuedLocalWorker, logging an error and exiting gracefully we circumvent this problem, providing more clarity to the root cause of the issue to the Airflow administrator.^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.