Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add airflow webserver URL into SLA miss email. #13249

Merged
merged 1 commit into from Dec 23, 2020

Conversation

abhishekbafna
Copy link
Contributor


^ Add meaningful description above

This adds the Airflow webserver base URL in the SLA miss notification email. This can be really helpful in cases where multiple airflow clusters are running and it identifies in which cluster it has happened. It also enables users to reach the airflow cluster with a single click from the email itself.

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Dec 22, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 22, 2020

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:

  • Pay attention to the quality of your code (flake8, pylint and type annotations). Our pre-commits will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Copy link
Member

@potiuk potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we see an example screenshot of such an email generated ?

@abhishekbafna
Copy link
Contributor Author

Can we see an example screenshot of such an email generated ?

Thank you for the review Jarek. Please find the screenshot of the email below.

PS: I have tested this on Airflow 1.10.4+ which we use internally. It's the same change for both the current master and 1.10.4 version.

Screenshot 2020-12-23 at 10 00 05 AM

@potiuk potiuk merged commit cb4755f into apache:master Dec 23, 2020
@boring-cyborg
Copy link

boring-cyborg bot commented Dec 23, 2020

Awesome work, congrats on your first merged pull request!

@potiuk
Copy link
Member

potiuk commented Dec 23, 2020

Nice!

@abhishekbafna
Copy link
Contributor Author

Thank you Jarek, I couldn't be happier.

@kaxil kaxil added this to the Airflow 2.1 milestone Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants