Fix link to Apache Airflow docs in webserver #13250

turbaszek · 2020-12-22T11:40:14Z

Current link returns 404
https://airflow.apache.org/docs/2.0.0

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

turbaszek · 2020-12-22T12:00:12Z

tests/utils/test_docs.py

-            self.assertEqual(expected_urk, get_docs_url(page))
+            self.assertEqual(expected_url, get_docs_url(page))
+            resp = requests.get(expected_url)
+            assert resp.status_code == 200


Not sure about sending requests (in general it's not best practice) but I don't know other way to make sure what we use works - without this the test gives false positives.

It seems fine in this case, but we can speed up this code a bit if we use HEAD requests.

github-actions · 2020-12-22T13:25:44Z

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

turbaszek · 2021-01-06T19:48:10Z

@kaxil should we mark it as 2.0.1?

kaxil · 2021-01-06T21:40:47Z

@kaxil should we mark it as 2.0.1?

Yup, just marked

tests/utils/test_docs.py

github-actions · 2021-01-12T12:33:05Z

The Workflow run is cancelling this PR. Building images for the PR has failed. Follow the the workflow link to check the reason.

github-actions · 2021-01-12T15:28:58Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

kaxil · 2021-01-19T22:30:04Z

Conflicting files here @turbaszek

github-actions · 2021-01-23T12:05:45Z

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

potiuk · 2021-01-24T04:31:04Z

The problems were temporary due to wrongly generated constraints (they were there generated from python3.8 in python 3.6 for about an hour by my mistake)

(cherry picked from commit c90485c)

apache#13250 missed a case to update URL in `tests/www/test_views.py`.

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 2a90473)

#13250 missed a case to update URL in `tests/www/test_views.py`.

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e40)

(cherry picked from commit c90485c)

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e40)

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e406fd20b91959d603a42f381b014e86d2b3) GitOrigin-RevId: 7c152906d55a98cca07ca81346f25d06fe578f1c

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e406fd20b91959d603a42f381b014e86d2b3) GitOrigin-RevId: 7c152906d55a98cca07ca81346f25d06fe578f1c

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

turbaszek requested review from kaxil and mik-laj December 22, 2020 11:40

turbaszek force-pushed the fix-docs-link branch from e8d9d21 to a9d62e9 Compare December 22, 2020 11:52

turbaszek commented Dec 22, 2020

View reviewed changes

kaxil approved these changes Dec 22, 2020

View reviewed changes

github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Dec 22, 2020

TobKed approved these changes Dec 22, 2020

View reviewed changes

turbaszek force-pushed the fix-docs-link branch from a9d62e9 to 358336b Compare January 6, 2021 11:40

kaxil added this to the Airflow 2.0.1 milestone Jan 6, 2021

turbaszek mentioned this pull request Jan 8, 2021

Fix redirect to / and /docs endpoint for some versions apache/airflow-site#362

Merged

mik-laj reviewed Jan 8, 2021

View reviewed changes

tests/utils/test_docs.py Outdated Show resolved Hide resolved

mik-laj approved these changes Jan 8, 2021

View reviewed changes

turbaszek force-pushed the fix-docs-link branch from 8039250 to f234670 Compare January 12, 2021 12:47

kaxil added the priority:low Bug with a simple workaround that would not block a release label Jan 19, 2021

turbaszek force-pushed the fix-docs-link branch from f234670 to fecd662 Compare January 23, 2021 11:17

turbaszek requested a review from kaxil January 23, 2021 11:18

Fix link to Apache Airflow docs in webserver

31f0788

turbaszek force-pushed the fix-docs-link branch from fecd662 to 31f0788 Compare January 23, 2021 13:01

kaxil approved these changes Jan 23, 2021

View reviewed changes

potiuk merged commit c90485c into apache:master Jan 24, 2021

potiuk deleted the fix-docs-link branch January 24, 2021 04:31

kaxil pushed a commit that referenced this pull request Jan 27, 2021

Fix link to Apache Airflow docs in webserver (#13250)

d254053

(cherry picked from commit c90485c)

kaxil added a commit to astronomer/airflow that referenced this pull request Jan 30, 2021

Fix docs url in tests

2a90473

apache#13250 missed a case to update URL in `tests/www/test_views.py`.

kaxil mentioned this pull request Jan 30, 2021

Fix docs url in tests #13992

Merged

kaxil added a commit that referenced this pull request Jan 30, 2021

Fix docs url in tests

c338996

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 2a90473)

XD-DENG pushed a commit that referenced this pull request Jan 31, 2021

Fix docs url in tests (#13992)

9840e40

#13250 missed a case to update URL in `tests/www/test_views.py`.

kaxil added a commit that referenced this pull request Feb 1, 2021

Fix docs url in tests (#13992)

0df63c7

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e40)

kaxil pushed a commit that referenced this pull request Feb 4, 2021

Fix link to Apache Airflow docs in webserver (#13250)

3d71e7d

(cherry picked from commit c90485c)

kaxil added a commit that referenced this pull request Feb 4, 2021

Fix docs url in tests (#13992)

7c15290

#13250 missed a case to update URL in `tests/www/test_views.py`. (cherry picked from commit 9840e40)

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 17, 2021

Fix docs url in tests (#13992)

42de4fe

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Sep 23, 2021

Fix docs url in tests (#13992)

99c4211

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Nov 27, 2021

Fix docs url in tests (#13992)

81281e2

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Mar 10, 2022

Fix docs url in tests (#13992)

ca5266a

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jun 4, 2022

Fix docs url in tests (#13992)

ddc3cfe

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

kosteev pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jul 9, 2022

Fix docs url in tests (#13992)

a4911f9

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Aug 27, 2022

Fix docs url in tests (#13992)

6f0df5b

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 4, 2022

Fix docs url in tests (#13992)

9ba12b3

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

aglipska pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Oct 7, 2022

Fix docs url in tests (#13992)

3d2adf5

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Dec 7, 2022

Fix docs url in tests (#13992)

e468973

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

leahecole pushed a commit to GoogleCloudPlatform/composer-airflow that referenced this pull request Jan 27, 2023

Fix docs url in tests (#13992)

3bfee72

apache/airflow#13250 missed a case to update URL in `tests/www/test_views.py`. GitOrigin-RevId: 9840e406fd20b91959d603a42f381b014e86d2b3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix link to Apache Airflow docs in webserver #13250

Fix link to Apache Airflow docs in webserver #13250

turbaszek commented Dec 22, 2020 •

edited

turbaszek Dec 22, 2020 •

edited

mik-laj Jan 8, 2021

github-actions bot commented Dec 22, 2020

turbaszek commented Jan 6, 2021

kaxil commented Jan 6, 2021

github-actions bot commented Jan 12, 2021

github-actions bot commented Jan 12, 2021

kaxil commented Jan 19, 2021

github-actions bot commented Jan 23, 2021

potiuk commented Jan 24, 2021

Fix link to Apache Airflow docs in webserver #13250

Fix link to Apache Airflow docs in webserver #13250

Conversation

turbaszek commented Dec 22, 2020 • edited

turbaszek Dec 22, 2020 • edited

Choose a reason for hiding this comment

mik-laj Jan 8, 2021

Choose a reason for hiding this comment

github-actions bot commented Dec 22, 2020

turbaszek commented Jan 6, 2021

kaxil commented Jan 6, 2021

github-actions bot commented Jan 12, 2021

github-actions bot commented Jan 12, 2021

kaxil commented Jan 19, 2021

github-actions bot commented Jan 23, 2021

potiuk commented Jan 24, 2021

turbaszek commented Dec 22, 2020 •

edited

turbaszek Dec 22, 2020 •

edited