Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support tables in DAG docs #13533

Merged
merged 6 commits into from Jan 15, 2021
Merged

Support tables in DAG docs #13533

merged 6 commits into from Jan 15, 2021

Conversation

jyotidhiman0610
Copy link
Contributor

Closes #10367

@boring-cyborg boring-cyborg bot added the area:webserver Webserver related Issues label Jan 7, 2021
@mik-laj
Copy link
Member

mik-laj commented Jan 7, 2021

Can you add tests to avoid regression? It's also the easiest way to get reviews faster, as the reviewer won't have to run the change locally.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Jan 7, 2021
@github-actions
Copy link

github-actions bot commented Jan 7, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@jyotidhiman0610
Copy link
Contributor Author

@ryanahamilton @mik-laj I pushed a space to re-run the failing tests/(seemed unrelated) & get a green build on the PR. Post that, I think we can be good to merge.
Do let me know if there is any other way to run failing tests.
Thanks

@jyotidhiman0610
Copy link
Contributor Author

I re-based to latest master & pushed. Hoping the tests run now!

@mik-laj mik-laj changed the title Fix Table not rendering in DAG Docs Support table in DAG docs Jan 15, 2021
@mik-laj mik-laj changed the title Support table in DAG docs Support tables in DAG docs Jan 15, 2021
@mik-laj mik-laj merged commit 3558538 into apache:master Jan 15, 2021
@jyotidhiman0610
Copy link
Contributor Author

jyotidhiman0610 commented Jan 15, 2021 •
edited

Thanks @mik-laj for closing the issue :)

@mik-laj
Copy link
Member

mik-laj commented Jan 15, 2021

Thanks @jyotidhiman0610 for your contribution. What's next? 🐈‍⬛

kaxil pushed a commit that referenced this pull request Jan 21, 2021
@jyotidhiman0610 @kaxil
Support tables in DAG docs (#13533)
2fc8fa8 
(cherry picked from commit 3558538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanahamilton ryanahamilton ryanahamilton approved these changes

@mik-laj mik-laj mik-laj approved these changes

Assignees
No one assigned
Labels
area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Markdown table is not rendered in doc_md attribute for DAG
3 participants
@jyotidhiman0610 @mik-laj @ryanahamilton