Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add __repr__ for Executors #13753

Merged
merged 1 commit into from Jan 18, 2021
Merged

Add __repr__ for Executors #13753

merged 1 commit into from Jan 18, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Jan 18, 2021

Before:

>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
<airflow.executors.local_executor.LocalExecutor object at 0x7f49b47f8d68>

After:

>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
LocalExecutor(parallelism=32)

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

Before:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
<airflow.executors.local_executor.LocalExecutor object at 0x7f49b47f8d68>
```

After:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
LocalExecutor(parallelism=32)
```
@kaxil kaxil added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Jan 18, 2021
@boring-cyborg boring-cyborg bot added the area:Scheduler Scheduler or dag parsing Issues label Jan 18, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 18, 2021
@kaxil kaxil merged commit 6410f07 into apache:master Jan 18, 2021
@kaxil kaxil deleted the repr-exec branch January 18, 2021 22:10
kaxil added a commit that referenced this pull request Jan 21, 2021
Before:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
<airflow.executors.local_executor.LocalExecutor object at 0x7f49b47f8d68>
```

After:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
LocalExecutor(parallelism=32)
```

(cherry picked from commit 6410f07)
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 12, 2021
Before:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
<airflow.executors.local_executor.LocalExecutor object at 0x7f49b47f8d68>
```

After:

```python
>>> from airflow.executors.local_executor import LocalExecutor
>>> LocalExecutor()
LocalExecutor(parallelism=32)
```

(cherry picked from commit 6410f07)
(cherry picked from commit 46e46e8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants