New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop loading Extra Operator links in Scheduler #13932
Conversation
6b3d134
to
8a91a4c
Compare
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Backport packages$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
8a91a4c
to
d05942e
Compare
The Workflow run is cancelling this PR. Building image for the PR has been cancelled |
d05942e
to
4343dda
Compare
@ephraimbuddy @jhtimmins Can you take a look and review too please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this approach to the global state of environment variables. Is it necessary to pass load_op_links
to DagBag's constructor though?
I'm not super familiar with the how this is used, so it might not make sense, but could it be passed directly to deserialize_operator
as an argument?
Mainly to reduce the places we need to pass the flag otherwise -- dab163e is my first commit where I tried something similar but its too ugly -- I passed it all the over the place |
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
closes #13099
Mutually exclusive with #13931
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.