Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scheduler should not fail when invalid executor_config is passed #14323

Merged
merged 2 commits into from Feb 20, 2021

Conversation

kaxil
Copy link
Member

@kaxil kaxil commented Feb 19, 2021

closes #14182


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@kaxil kaxil added this to the Airflow 2.0.2 milestone Feb 19, 2021
@kaxil kaxil requested a review from dimberman February 19, 2021 21:12
@boring-cyborg boring-cyborg bot added provider:cncf-kubernetes Kubernetes provider related issues area:Scheduler Scheduler or dag parsing Issues labels Feb 19, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 19, 2021
airflow/executors/kubernetes_executor.py Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the full tests needed We need to run full set of tests for this PR to merge label Feb 19, 2021
@kaxil kaxil dismissed XD-DENG’s stale review February 20, 2021 00:46

Changes applied

@kaxil kaxil merged commit e0ee91e into apache:master Feb 20, 2021
@kaxil kaxil deleted the fix-k8s branch February 20, 2021 00:46
@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Feb 20, 2021
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil kaxil moved this from To Do to Done in Kubernetes Issues - Sprint Feb 24, 2021
ashb pushed a commit that referenced this pull request Mar 19, 2021
kaxil added a commit to astronomer/airflow that referenced this pull request Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:Scheduler Scheduler or dag parsing Issues full tests needed We need to run full set of tests for this PR to merge provider:cncf-kubernetes Kubernetes provider related issues
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Scheduler dies if executor_config isnt passed a dict when using K8s executor
3 participants