Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify configuration/legibility of Webpack entries #14551

Merged
merged 1 commit into from Mar 1, 2021

Conversation

ryanahamilton
Copy link
Contributor

Replaces STATIC_DIR with CSS_DIR and JS_DIR to simplify configuration of their respective files.

@ryanahamilton ryanahamilton requested a review from ashb as a code owner March 1, 2021 21:19
@boring-cyborg boring-cyborg bot added area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues labels Mar 1, 2021
@bbovenzi
Copy link
Contributor

bbovenzi commented Mar 1, 2021

That makes sense to me. Keeps things simpler.

@github-actions
Copy link

github-actions bot commented Mar 1, 2021

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 1, 2021
@ryanahamilton ryanahamilton merged commit aa08382 into apache:master Mar 1, 2021
@ryanahamilton ryanahamilton deleted the webpack_config_cleanup branch June 1, 2021 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:UI Related to UI/UX. For Frontend Developers. area:webserver Webserver related Issues okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants