Add minimum version of pylint #14775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using some pylint rules that were added in pylint 2.7.0, for example `consider-using-generator`. When older version of pylint is used, it fails with this error: * E0012: Bad option value 'consider-using-generator' (bad-option-value) Adding lower-limit forces the pylint to be upgraded even if someone's image or installation already had pylint installed.
potiuk
requested review from
kaxil,
mik-laj,
ashb,
turbaszek,
XD-DENG,
dstandish,
ephraimbuddy and
BasPH
mik-laj
approved these changes
Mar 14, 2021
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
r-richmond
added a commit
to r-richmond/airflow
that referenced
this pull request
Mar 14, 2021
* master: (189 commits) Fixes case where output log is missing for image waiting (apache#14784) Only rebuilds base python image when upgrading to newer deps (apache#14783) Better diagnostics for image waiting (apache#14779) Fixes limits on Arrow for plexus test (apache#14781) Add script to verify that all artefacts are in svn (apache#14777) Add minimum version of pylint (apache#14775) Refactor info command to use AirflowConsole (apache#14757) Add Helm Chart logo to docs index (apache#14762) Add elasticsearch to the fixes of backport providers (apache#14763) Update documentation for broken package releases (apache#14734) Prepare for releasing Elasticsearch Provider 1.0.3 (apache#14748) Excludes .git-modules from rat-check (apache#14759) Fixes force-pulling base python images (apache#14736) Rename DateTimeBranchOperator to BranchDateTimeOperator (apache#14720) Remove Heisentest category and quarantine test_backfill_depends_on_past (apache#14756) `./breeze stop` is not necessary for new comers apache#14752 (apache#14753) Add confirming getopt and gstat apache#14750 (apache#14751) Small fixes in provider preparation docs (apache#14689) Fix attributes for AzureDataFactory hook (apache#14704) Refactor Taskflow decorator for extensibility (apache#14709) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using some pylint rules that were added in pylint 2.7.0,
for example
consider-using-generator. When older version ofpylint is used, it fails with this error:
Adding lower-limit forces the pylint to be upgraded even if
someone's image or installation already had pylint installed.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.