Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for Docker Image docs #14843

Merged
merged 3 commits into from May 23, 2021
Merged

Improvements for Docker Image docs #14843

merged 3 commits into from May 23, 2021

Conversation

@mik-laj
Copy link
Member

@mik-laj mik-laj commented Mar 17, 2021


^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@@ -25,68 +25,6 @@ In some cases, you can pass environment variables to the image to trigger some o
The variables that control the "execution" behaviour start with ``_AIRFLOW`` to distinguish them
from the variables used to build the image starting with ``AIRFLOW``.

The image entrypoint works as follows:
Copy link
Member Author

@mik-laj mik-laj Mar 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section contains a lot of information, which is repeated again in the sections below.

kaxil
kaxil approved these changes Mar 17, 2021
@github-actions
Copy link

@github-actions github-actions bot commented Mar 17, 2021

The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@mik-laj mik-laj force-pushed the image-docs branch 2 times, most recently from 4f59afc to cc82bc7 Apr 3, 2021
potiuk
potiuk approved these changes Apr 3, 2021
@potiuk
Copy link
Member

@potiuk potiuk commented Apr 3, 2021

Build doc is failing @mik-laj

@potiuk
Copy link
Member

@potiuk potiuk commented Apr 4, 2021

Looks like some temporary problem from yesterday - rebasing and push --forceing now.

@github-actions
Copy link

@github-actions github-actions bot commented Apr 6, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

@github-actions github-actions bot commented Apr 6, 2021

The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*.

@github-actions
Copy link

@github-actions github-actions bot commented May 23, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label May 23, 2021
@mik-laj
Copy link
Member Author

@mik-laj mik-laj commented May 23, 2021

Rebased.

@mik-laj mik-laj merged commit 5dfda56 into apache:master May 23, 2021
27 checks passed
andormarkus pushed a commit to andormarkus/airflow that referenced this issue Jun 5, 2021
* Improvments for Docker Image docs

* fixup! Improvments for Docker Image docs

* fixup! fixup! Improvments for Docker Image docs
potiuk added a commit to potiuk/airflow that referenced this issue Jun 22, 2021
* Improvments for Docker Image docs

* fixup! Improvments for Docker Image docs

* fixup! fixup! Improvments for Docker Image docs

(cherry picked from commit 5dfda56)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants