Turn provider's import warnings into debug logs #14903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
reviewed
Mar 19, 2021
potiuk
force-pushed
the
remove-warnings-from-providers-manager
branch
from
e524653
to
c0196c8
Compare
|
I simplified it a it more and added comment @ashb -> i simply turn all the ImportErrors into debug. |
ashb
reviewed
Mar 19, 2021
When only some providers are installed, cross-dependencies between the providers might cause import erors. Those import errors are repeated in webserver as it is reloaded every 30 seconds. Since "only some providers" case is valid, it should not generate warrnings if it is an ImportError. Those warnings are now turned into debug messages. Fixes: apache#14286
potiuk
force-pushed
the
remove-warnings-from-providers-manager
branch
from
c0196c8
to
146d4d4
Compare
ashb
approved these changes
Mar 19, 2021
|
Should be updaed now. |
|
The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease. |
github-actions
bot
added
the
okay to merge
38 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When only some providers are installed, cross-dependencies between
the providers might cause import erors. Those import errors are
repeated in webserver as it is reloaded every 30 seconds.
Since "only some providers" case is valid, it should not generate
warrnings if it is an ImportError. Those warnings are now
turned into debug messages.
Fixes: #14286
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.