Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove user_id from API schema #15117

Merged
merged 2 commits into from Apr 7, 2021
Merged

Conversation

uranusjr
Copy link
Member

Fix #15059. The role schema doesn't seem to contain an ID at all (only the role name), so I just removed the user ID.


Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@boring-cyborg boring-cyborg bot added the area:API Airflow's REST/HTTP API label Mar 31, 2021
@github-actions github-actions bot added the okay to merge It's ok to merge this PR as it does not require more tests label Mar 31, 2021
@github-actions
Copy link

The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest master or amend the last commit of the PR, and push it with --force-with-lease.

@kaxil
Copy link
Member

kaxil commented Apr 2, 2021

Can you take a look at the failing tests please @uranusjr

@uranusjr
Copy link
Member Author

uranusjr commented Apr 7, 2021

What are quarantined tests, and how do I read logs for their failures? I can see some of them are failing (in test_views.py and test_local_task_jobs.py), but can’t find what tests exactly and why.

@kaxil
Copy link
Member

kaxil commented Apr 7, 2021

What are quarantined tests, and how do I read logs for their failures? I can see some of them are failing (in test_views.py and test_local_task_jobs.py), but can’t find what tests exactly and why.

Quarantined test failures can be ignored, they are mostly flaky tests, docs for it are here: https://github.com/apache/airflow/blob/master/TESTING.rst#quarantined-tests

Some of our tests are quarantined. This means that this test will be run in isolation and that it will be re-run several times. Also when quarantined tests fail, the whole test suite will not fail. The quarantined tests are usually flaky tests that need some attention and fix.

Those tests are marked with @pytest.mark.quarantined annotation. Those tests are skipped by default. You can enable them with --include-quarantined flag. You can also decide to only run tests with -m quarantined flag to run only those tests.

@kaxil kaxil merged commit 7087541 into apache:master Apr 7, 2021
@uranusjr uranusjr deleted the remove-user-id-from-api branch April 7, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:API Airflow's REST/HTTP API okay to merge It's ok to merge this PR as it does not require more tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 'user_id', 'role_id' from User and Role in OpenAPI schema
2 participants