Add BigQueryToMsSqlOperator #15422
Add BigQueryToMsSqlOperator #15422
Conversation
…nthi/bigquery_mssql_operator_15145
boring-cyborg
bot
added
area:providers
provider:google
| self.location = location | ||
| self.impersonation_chain = impersonation_chain | ||
| try: | ||
| self.dataset_id, self.table_id = dataset_table.split('.') |
There was a problem hiding this comment.
How about project.dataset.table ? You can utilise method from bq library to parse string into database/table reference
There was a problem hiding this comment.
Thanks, let me check that.
There was a problem hiding this comment.
Im looking at https://googleapis.dev/python/bigquery/latest/reference.html and I can't find the method to parse string into database/table, can u please point me to the right library.
There was a problem hiding this comment.
There was a problem hiding this comment.
@turbaszek made the change.
…nthi/bigquery_mssql_operator_15145
Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
Code change based on review comments. Co-authored-by: Tomek Urbaszek <turbaszek@gmail.com>
…query_mssql_operator_15145
…nthi/bigquery_mssql_operator_15145
eladkal
changed the title
|
Hey @subkanthi do you need some help? |
|
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
|
The Workflow run is cancelling this PR. It has some failed jobs matching ^Pylint$,^Static checks,^Build docs$,^Spell check docs$,^Provider packages,^Checks: Helm tests$,^Test OpenAPI*. |
Hi @turbaszek can you please review again, I fixed the unit test that was failing because of the project id, Thanks |
airflow/providers/google/cloud/example_dags/example_bigquery_to_mssql.py
Outdated
Show resolved
Hide resolved
closes: #15145
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.