Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OdbcHook returns None. Related to #15016 issue. #15510

Merged
merged 7 commits into from Jun 13, 2021
Merged

OdbcHook returns None. Related to #15016 issue. #15510

merged 7 commits into from Jun 13, 2021

Commits on Apr 23, 2021

  1. OdbcHook returns None. Related to #15016 issue.

    This PR is related to #15016 issue.
    OdbcHook returns None for non-boolean-like string values in connect_kwargs dict arg, however connect_kwarg values should remain as is in this case.
    Goodkat committed Apr 23, 2021
    Configuration menu
    Copy the full SHA
    7c5bf0d View commit details
    Browse the repository at this point in the history

Commits on Apr 26, 2021

  1. Removed clean_bool

    According to the discussion on #15016, we agreed to remove the clean_bool function, as it is not needed actually for processing boolean values in JSON .
    Goodkat committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    3ec60b1 View commit details
    Browse the repository at this point in the history
  2. Update odbc docs

    Removed quotas for the boolean values accroding to the discussion on #15016 issue.
    Goodkat committed Apr 26, 2021
    Configuration menu
    Copy the full SHA
    a1bc9b6 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2021

  1. Update odbc.py

    Fixed the failing pydocstyle test: No blank lines allowed after function docstring (found 1)
    Goodkat committed May 10, 2021
    Configuration menu
    Copy the full SHA
    f2acbbc View commit details
    Browse the repository at this point in the history
  2. Update odbc.py

    Fixed failing pylint check. R1721: Unnecessary use of a comprehension
    Goodkat committed May 10, 2021
    Configuration menu
    Copy the full SHA
    9fed083 View commit details
    Browse the repository at this point in the history
  3. Update test_odbc.py

    Integration Test has been changed as it should all work correctly with unquoted raw JSON booleans, which should make clean_bool unnecessary.
    Goodkat committed May 10, 2021
    Configuration menu
    Copy the full SHA
    dbe1e8a View commit details
    Browse the repository at this point in the history
  4. Update test_odbc.py

    Fixed input parameter {'ansi': true} -> {'ansi': True}
    Goodkat committed May 10, 2021
    Configuration menu
    Copy the full SHA
    2bee173 View commit details
    Browse the repository at this point in the history