Removes unnecessary AzureContainerInstance connection type #15514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boring-cyborg
bot
added
area:providers
provider:microsoft-azure
potiuk
force-pushed
the
fix-azure-provider-warnings
branch
from
33ea9c5
to
8821a93
Compare
potiuk
force-pushed
the
fix-azure-provider-warnings
branch
from
8821a93
to
f9069d3
Compare
github-actions
bot
added
the
full tests needed
|
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease. |
The AzureContainerInstanceHook was derived from AzureBaseHook and it did not add any new connection fields. Instead it duplicated the tennantId and subscriptionId extr behaviour, but it never worked, because it duplicated the fields from the AzureBaseHook - and caused a lot of warnings when AzureProvider was added. This change sets the default connection type for the AzureContainerInstanceHook to be azure_default and the connection type to be 'azure'. Those defaults are much more 'sane'. The existing connections will continue to work, only when you open them in the UI, they will display the extras directly rather than in dedicated fields until the user changes the connection type to "azure" which will fix the display. So no disruptions, just temporary UI/Editing glitch. No more warnings printed when Azure provider is added.
potiuk
force-pushed
the
fix-azure-provider-warnings
branch
from
f9069d3
to
e32de27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AzureContainerInstanceHook was derived from AzureBaseHook
and it did not add any new connection fields. Instead
it duplicated the tennantId and subscriptionId extr behaviour,
but it never worked, because it duplicated the fields
from the AzureBaseHook - and caused a lot of warnings when
AzureProvider was added.
This change sets the default connection type for the
AzureContainerInstanceHook to be azure_default and the
connection type to be 'azure'.
Those defaults are much more 'sane'. The existing connections
will continue to work, only when you open them in the UI, they
will display the extras directly rather than in dedicated fields
until the user changes the connection type to "azure" which will
fix the display.
So no disruptions, just temporary UI/Editing glitch. No more warnings
printed when Azure provider is added.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.